The public CPP API from PGM should rely on c++17 standard #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
TonyXiang8787
commented
Mar 24, 2025
|
@mgovers if that is the only non-compliant code. Feel free to approve and merge the PR. |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
reviewed
Mar 24, 2025
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/handle.hpp
Show resolved
Hide resolved
mgovers
approved these changes
Mar 24, 2025
|
Jerry-Jinfeng-Guo
added
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public CPP API of PGM should rely on c++17 standard as decided by the TSC. However, there are c++20 features used. In this PR we force the package test to build in c++17. And the error will show up.