-
Notifications
You must be signed in to change notification settings - Fork 35
Basic PGM support for creating current sensors (experimental in state estimation) #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…m/PowerGridModel/power-grid-model into feature/current-sensor-main-model Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
found a segfault that requires attention EDIT: fixed in 24241ed |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/topology.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces experimental support for current sensors in both the C++ core and Python wrapper for state estimation. It adds enum entries for symmetric and asymmetric current sensors.
- Added enum entries for symmetric and asymmetric current sensors to dataset_definitions.py
- Supports experimental behavior for handling current sensors in state estimation
Files not reviewed (19)
- code_generation/data/dataset_class_maps/dataset_definitions.json: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/all_components.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/calculation_parameters.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/main_core/topology.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/main_model.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp: Language not supported
- power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp: Language not supported
- power_grid_model_c/power_grid_model_c/include/power_grid_model_c/dataset_definitions.h: Language not supported
- power_grid_model_c/power_grid_model_c/src/dataset_definitions.cpp: Language not supported
- power_grid_model_c/power_grid_model_c/src/model.cpp: Language not supported
- tests/data/state_estimation/basic-current-sensor/input.json: Language not supported
- tests/data/state_estimation/basic-current-sensor/input.json.license: Language not supported
- tests/data/state_estimation/basic-current-sensor/params.json: Language not supported
- tests/data/state_estimation/basic-current-sensor/params.json.license: Language not supported
- tests/data/state_estimation/basic-current-sensor/sym_output.json: Language not supported
- tests/data/state_estimation/basic-current-sensor/sym_output.json.license: Language not supported
- tests/native_api_tests/test_api_model.cpp: Language not supported
Comments suppressed due to low confidence (2)
src/power_grid_model/_core/dataset_definitions.py:74
- [nitpick] Consider reordering the enum entries to follow a consistent order (e.g., alphabetical) to enhance code readability.
sym_current_sensor = "sym_current_sensor"
src/power_grid_model/_core/dataset_definitions.py:75
- [nitpick] Consider reordering the enum entries to follow a consistent order (e.g., alphabetical) to enhance code readability.
asym_current_sensor = "asym_current_sensor"
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/topology.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/topology.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Show resolved
Hide resolved
@TonyXiang8787 you requested copilot but it's not properly set-up, cfr:
|
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
Make sure that the C++ core and Python wrapper can handle current sensors.
Relates to #547 .
This feature is experimental. The behavior is as follows:
InvalidArguments
with the messageState estimation is not implemented for current sensors!
NotObservableError
if there are not enough voltage and power sensors, even if the system is observable if current sensors are taken into account. This will be resolved in follow-up PRs