Skip to content

Current sensor: statistics + observability #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 15, 2025

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Apr 8, 2025

Part of #547

This implements:

  • In the observability check, treat the current sensor the same as power sensor. They both contribute to observability.
  • In the measured values, treat the current sensor similarly as power sensor, but accumulate separately.
    • If there is no voltage angle measurement but there are global angle current sensors in the connected component of the grid, throw an error
    • If there is a mixture of local and global angle current sensors on the same terminal (i.e., the same branch_from or branch_to of the same component), throw an error.
      • NOTE: it is supported to have a mixture as long as they are on different terminals, e.g., a local angle current sensor on the branch from side and a global angle current sensor on the branch to side of the same branch is OK.
  • Fixes prepare state estimation for current sensor
  • Refactors some measured values logic that is more generic

mgovers added 10 commits April 4, 2025 08:25
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…-type-values' into feature/current-sensor-math-solver

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the feature New feature or request label Apr 8, 2025
@mgovers mgovers self-assigned this Apr 8, 2025
mgovers and others added 7 commits April 8, 2025 09:03
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers added 2 commits April 10, 2025 08:01
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers added 2 commits April 10, 2025 10:08
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks from my side. Looks good overall.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers added 3 commits April 14, 2025 08:42
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…on trial run

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers enabled auto-merge April 14, 2025 13:15
Copy link

Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments. Looks good to me.

@mgovers mgovers added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 5d38475 Apr 15, 2025
30 checks passed
@mgovers mgovers deleted the feature/current-sensor-measurements-observability branch April 15, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants