Skip to content

current sensor: math solver implementation #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2025

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Apr 14, 2025

Part of #547 .

Adds the logic for current sensor to math solver.

mgovers added 2 commits April 9, 2025 08:44
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added feature New feature or request do-not-merge This should not be merged labels Apr 14, 2025
@mgovers mgovers self-assigned this Apr 14, 2025
@mgovers mgovers changed the title Feature/current sensor math solver current sensor: math solver implementation Apr 14, 2025
mgovers and others added 4 commits April 14, 2025 13:00
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review April 14, 2025 13:13
@mgovers
Copy link
Member Author

mgovers commented Apr 14, 2025

Quality Gate Passed Quality Gate passed

Issues 6 New issues 0 Accepted issues

Measures 0 Security Hotspots 100.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

4 sonar cloud warnings are intended TODO's for when NRSE current sensors are implemented; the other 2 are also already in main

Base automatically changed from feature/current-sensor-measurements-observability to main April 15, 2025 08:18
@mgovers mgovers removed the do-not-merge This should not be merged label Apr 15, 2025
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only minor comments.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers enabled auto-merge April 15, 2025 11:05
@mgovers mgovers added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 4ab0e9c Apr 15, 2025
30 checks passed
@mgovers mgovers deleted the feature/current-sensor-math-solver branch April 15, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants