-
Notifications
You must be signed in to change notification settings - Fork 39
Statistics: add scaling functionality #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4820105
to
a71a4ee
Compare
These set of One minor nitpick, could you add an in-code comment above the Oh, I will approve after possible merge conflicts (as stated in the introduction of the PR) are resolved. |
yes
what do you mean?
no merge conflicts because i had already resolved those |
As in, as taken from #547, just add: but for the actual variance scaling, above is just for demonstration of what I mean. So add an in-code comment with the formula.
Yup, realized after commenting. |
a71a4ee
to
ecf4e54
Compare
ca3749c
to
850e013
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
850e013
to
a206d17
Compare
|
This is a cherry-pick of the statistics functionality in #951 .
It adds
statistics::scale
functions next to the already presentstatistics::combine
functionsDo not merge before #947 and #954 are merged