-
Notifications
You must be signed in to change notification settings - Fork 35
Add markdownlint formatting checks #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
Has this been discussed to enable markdown linter in the repository? I feel this is a more project governance decision. |
Awaiting approval from the team (do-not-merge label) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I totally support the addition of markdown lint, maybe we should visit all the options with the team, as we should probably have a consensus on what to enable/disable. Besides that, great change.
Given #964, I have resolved all the comments I had. Now I see that there is a follow up to things that can't be addressed immediately and need further changes/discussion. Hereby I give my approval :) |
Team has approved |
pre-commit