Skip to content

Add markdownlint formatting checks #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2025
Merged

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Apr 22, 2025

mgovers added 5 commits April 22, 2025 14:11
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code labels Apr 22, 2025
@mgovers mgovers self-assigned this Apr 22, 2025
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review April 22, 2025 12:31
@mgovers mgovers requested review from nitbharambe and removed request for nitbharambe April 22, 2025 12:38
@mgovers mgovers enabled auto-merge April 22, 2025 12:38
@TonyXiang8787
Copy link
Member

Has this been discussed to enable markdown linter in the repository?

I feel this is a more project governance decision.

@mgovers mgovers added this pull request to the merge queue Apr 22, 2025
@nitbharambe nitbharambe removed this pull request from the merge queue due to a manual request Apr 22, 2025
@mgovers mgovers added the do-not-merge This should not be merged label Apr 22, 2025
@mgovers
Copy link
Member Author

mgovers commented Apr 22, 2025

Has this been discussed to enable markdown linter in the repository?

I feel this is a more project governance decision.

Awaiting approval from the team (do-not-merge label)

Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I totally support the addition of markdown lint, maybe we should visit all the options with the team, as we should probably have a consensus on what to enable/disable. Besides that, great change.

@figueroa1395
Copy link
Contributor

While I totally support the addition of markdown lint, maybe we should visit all the options with the team, as we should probably have a consensus on what to enable/disable. Besides that, great change.

Given #964, I have resolved all the comments I had. Now I see that there is a follow up to things that can't be addressed immediately and need further changes/discussion. Hereby I give my approval :)

@mgovers mgovers removed the do-not-merge This should not be merged label Apr 23, 2025
@mgovers
Copy link
Member Author

mgovers commented Apr 23, 2025

Has this been discussed to enable markdown linter in the repository?
I feel this is a more project governance decision.

Awaiting approval from the team (do-not-merge label)

Team has approved

@mgovers mgovers added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit f85ad48 Apr 23, 2025
31 of 32 checks passed
@mgovers mgovers deleted the feature/minor-format-docs4 branch April 23, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants