Skip to content

Solve some markdownlint issues #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025
Merged

Solve some markdownlint issues #964

merged 5 commits into from
Apr 23, 2025

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Apr 22, 2025

  • add markdownlint to VSCode workspace recommendations

Resolve the following markdownlint issues:

NOTE: the following ones are still remaining:

mgovers added 3 commits April 22, 2025 14:33
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers self-assigned this Apr 22, 2025
@mgovers mgovers added the documentation Improvements or additions to documentation label Apr 22, 2025
@mgovers mgovers marked this pull request as ready for review April 22, 2025 12:57
@mgovers mgovers added the do-not-merge This should not be merged label Apr 22, 2025
@mgovers
Copy link
Member Author

mgovers commented Apr 22, 2025

Awaiting approval from the team (do-not-merge label)

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers mentioned this pull request Apr 23, 2025
8 tasks
figueroa1395
figueroa1395 previously approved these changes Apr 23, 2025
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers removed the do-not-merge This should not be merged label Apr 23, 2025
Base automatically changed from feature/minor-format-docs4 to main April 23, 2025 08:27
@mgovers mgovers dismissed stale reviews from petersalemink95 and figueroa1395 April 23, 2025 08:27

The base branch was changed.

@mgovers mgovers enabled auto-merge April 23, 2025 08:45
@mgovers mgovers added this pull request to the merge queue Apr 23, 2025
@mgovers mgovers removed this pull request from the merge queue due to a manual request Apr 23, 2025
@mgovers
Copy link
Member Author

mgovers commented Apr 23, 2025

I see that the PyPI job has not triggered yet on the current release v1.10.89. Awaiting resolution there

@mgovers mgovers added this pull request to the merge queue Apr 23, 2025
@mgovers
Copy link
Member Author

mgovers commented Apr 23, 2025

Seems deeper and not something we can (re)solve automatically. I manually kicked off the publish pipeline to unblock this and other work. NOTE: we will need to do the same until a permanent solution is implemented

Merged via the queue into main with commit fc123b3 Apr 23, 2025
30 of 31 checks passed
@mgovers mgovers deleted the feature/minor-format-docs2 branch April 23, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants