Voltage sensor angle residual mod 2pi #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
figueroa1395
previously approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Only a small related-ish comment. Rest looks good.
NOTE: this PR changes the PGM behavior slightly, but it should only be an improvement to the output for users.
Also, I see all the validation tests remained intact, so this should be okay. If anything, users would now face corrections.
power_grid_model_c/power_grid_model/include/power_grid_model/component/voltage_sensor.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/voltage_sensor.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
TonyXiang8787
approved these changes
Apr 29, 2025
|
Jerry-Jinfeng-Guo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voltage angle residuals currently can be in the range
[-2pi, 2pi]. This PR restricts it to the range(-pi, pi], effectively doingmod 2pi. This is also cfr. #961 and #962NOTE: this PR changes the PGM behavior slightly, but it should only be an improvement to the output for users.