-
Notifications
You must be signed in to change notification settings - Fork 35
Release v1.11.x #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v1.11.x #998
Conversation
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the v1.11.x release, addressing issue #976 by updating documentation warnings and bumping the project version.
- Removed outdated experimental warnings for current sensors in the user manual and replaced them with a more specific warning regarding Newton-Raphson state estimation.
- Updated the VERSION file from 1.10 to 1.11.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
docs/user_manual/components.md | Revised warning text for current sensor state estimation issues. |
VERSION | Updated version number to reflect the new release. |
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates functionality related to experimental features in state estimation by removing experimental feature flags from error handling tests and core logic, as well as adjusting related documentation and API tests.
- Removed the use of experimental features in state estimation calls within unit tests.
- Removed the experimental current sensor test block from the native API tests.
- Updated the main model implementation to disable experimental feature checks and revised documentation warnings accordingly.
- Bumped the project version from 1.10 to 1.11.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/unit/test_error_handling.py | Removed the experimental features parameter from state estimation function calls. |
tests/native_api_tests/test_api_model.cpp | Removed the experimental test block for current sensor validation. |
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp | Emptied the experimental features check function, effectively deprecating the check. |
docs/user_manual/components.md | Updated warning messages related to current sensor experimental status. |
VERSION | Bumped the version to reflect the updated release. |
Comments suppressed due to low confidence (1)
tests/native_api_tests/test_api_model.cpp:1062
- [nitpick] Removal of the experimental current sensor test block requires ensuring that alternative tests cover the current sensor behavior adequately, so verify that all key scenarios remain tested.
SUBCASE("Current sensor is experimental") { ... }
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
|
Solves #976