Skip to content

Release v1.11.x #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Release v1.11.x #998

wants to merge 3 commits into from

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

Solves #976

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this May 16, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label May 16, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo mentioned this pull request May 16, 2025
17 tasks
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo requested a review from Copilot May 16, 2025 13:42
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as draft May 16, 2025 13:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the v1.11.x release, addressing issue #976 by updating documentation warnings and bumping the project version.

  • Removed outdated experimental warnings for current sensors in the user manual and replaced them with a more specific warning regarding Newton-Raphson state estimation.
  • Updated the VERSION file from 1.10 to 1.11.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/user_manual/components.md Revised warning text for current sensor state estimation issues.
VERSION Updated version number to reflect the new release.

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo requested a review from Copilot May 16, 2025 14:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates functionality related to experimental features in state estimation by removing experimental feature flags from error handling tests and core logic, as well as adjusting related documentation and API tests.

  • Removed the use of experimental features in state estimation calls within unit tests.
  • Removed the experimental current sensor test block from the native API tests.
  • Updated the main model implementation to disable experimental feature checks and revised documentation warnings accordingly.
  • Bumped the project version from 1.10 to 1.11.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/unit/test_error_handling.py Removed the experimental features parameter from state estimation function calls.
tests/native_api_tests/test_api_model.cpp Removed the experimental test block for current sensor validation.
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp Emptied the experimental features check function, effectively deprecating the check.
docs/user_manual/components.md Updated warning messages related to current sensor experimental status.
VERSION Bumped the version to reflect the updated release.
Comments suppressed due to low confidence (1)

tests/native_api_tests/test_api_model.cpp:1062

  • [nitpick] Removal of the experimental current sensor test block requires ensuring that alternative tests cover the current sensor behavior adequately, so verify that all key scenarios remain tested.
SUBCASE("Current sensor is experimental") { ... }

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant