Add a check to validate if pincode #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
May 4, 2021
Comment on lines
58
to
59
| if len(pinCode) == 0 && (len(state) == 0 || len(district) == 0) { | ||
| return errors.New("Missing state or district name option") |
Owner
There was a problem hiding this comment.
Hey @SushilG96, this was to check if none of Pincode or state/district is set. For Pincode validation, we should probably add a separate check below this.
Add a check if the Pincode is valid or not. [Source-wiki] A Postal Index Number (PIN), or sometimes PIN code refers to a six-digit code in the Indian postal code system used by India Post. Signed-off-by: SushilG96 <susgupta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is opened to fix issue #4
Add a check if the Pincode is valid or not.
[Source-wiki] A Postal Index Number (PIN), or sometimes PIN code
refers to a six-digit code in the Indian postal code system used
by India Post.
Signed-off-by: SushilG96 susgupta@redhat.com