Skip to content

Change filename to upload on S3 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Change filename to upload on S3 #523

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f985aed
comparison report unification
karan-batavia Sep 11, 2024
8a20ac1
Merge branch 'dev' of https://github.com/Privado-Inc/privado into fix…
karan-batavia Sep 19, 2024
1a996ce
fix file name in comparison report
karan-batavia Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/comparison-result.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
FILE_SUFFIX: ${{ matrix.language }}-${{ env.PR_NUMBER }}
AWS_DEFAULT_REGION: ${{ env.AWS_REGION }}
TTL: 604800
run: echo "S3_URL=$(aws s3 presign ${{ secrets.S3_BUCKET }}/result-${{ env.FILE_SUFFIX }}.zip --expires-in ${{ env.TTL }} --region ${{ env.AWS_DEFAULT_REGION }} --endpoint-url https://s3.${{ env.AWS_DEFAULT_REGION }}.amazonaws.com)" >> $GITHUB_ENV
run: echo "S3_URL=$(aws s3 presign ${{ secrets.S3_BUCKET }}/result-rules-${{ env.FILE_SUFFIX }}.zip --expires-in ${{ env.TTL }} --region ${{ env.AWS_DEFAULT_REGION }} --endpoint-url https://s3.${{ env.AWS_DEFAULT_REGION }}.amazonaws.com)" >> $GITHUB_ENV

- name: Set summary variable
run: |
Expand Down
Loading