Improve error message for identifiers with leading underscore #28909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #28897
When users write identifiers starting with underscore, (e.g.: let _c: u32), the parser produces an uninformative error.
Root cause of that is that lexer splits
_c
into two separate tokens, and the parser had no grammar rule matching the pattern, so LARLPOP generates a generir error listing what tokens it expected at that position (which happened to be '(' for tuple destructuring).So, this adds new lexer token -
InvalidLeadingUnderscoreIdent
that catches any leading underscore next to identifiers.Before:
After:
Resolves: #28755