Skip to content

[Feature] LoggableError trait #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: staging
Choose a base branch
from
Open

[Feature] LoggableError trait #2944

wants to merge 8 commits into from

Conversation

kaimast
Copy link
Collaborator

@kaimast kaimast commented Oct 6, 2025 •
edited
Loading

This PR introduce the LoggableError trait which enables to easily log anyhow::Errors in snarkVM. This allows to have a more uniformed error logging mechanisms across snarkOS/snarkVM.
The PR's changes are also included in #2927, but the latter is already very complex and the logging changes are self-contained.

To see how LoggableError can be used, see the changes in ledger/store in 71a6665.

Notes

  • This changes some of the error logging functions introduced in [Feature] Improve Error Handling #2813, which makes it a breaking change. As far as I know, these functions are not (yet) used outside snarkVM and snarkOS.

@kaimast kaimast force-pushed the feat/loggable-error branch 4 times, most recently from bde959b to d73fc53 Compare October 7, 2025 04:43
@kaimast kaimast changed the base branch from staging to ci/semver-errors October 7, 2025 04:43
@kaimast kaimast force-pushed the ci/semver-errors branch 2 times, most recently from b1e95e4 to 72dd553 Compare October 7, 2025 05:24
Base automatically changed from ci/semver-errors to staging October 7, 2025 20:27
@vicsn vicsn requested a review from ljedrz October 8, 2025 16:59
@kaimast kaimast force-pushed the feat/loggable-error branch from d73fc53 to 0a6d913 Compare October 8, 2025 19:31
@kaimast kaimast marked this pull request as ready for review October 9, 2025 04:41
ljedrz
ljedrz reviewed Oct 9, 2025
View reviewed changes
ljedrz
ljedrz reviewed Oct 9, 2025
View reviewed changes
ljedrz
ljedrz reviewed Oct 9, 2025
View reviewed changes
ljedrz
ljedrz reviewed Oct 9, 2025
View reviewed changes
@kaimast
Copy link
Collaborator Author

kaimast commented Oct 10, 2025

Thanks for the feedback! I updated all the assert messages.

@kaimast kaimast requested a review from ljedrz October 17, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljedrz ljedrz Awaiting requested review from ljedrz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaimast @ljedrz