-
Notifications
You must be signed in to change notification settings - Fork 16
Pectra upgrade #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eladiosch
wants to merge
85
commits into
master
Choose a base branch
from
feat/pectra-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pectra upgrade #115
Changes from 3 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
2a4e501
Implemented flow to trigger validators exit
eladiosch d5b1a1e
Added role to trigger validators exit
eladiosch 607aa38
Removed references to enclave in PufferProtocol and adapted tests (WIP)
eladiosch 03e6b6d
Changed unused enclave variables to deprecated. Removed unused code
eladiosch 0a81b7e
Removed getPayload function
eladiosch bddc349
Adapted remaining failing tests
eladiosch 1f7b508
Added tests for new flow
eladiosch f5f8a40
forge fmt
eladiosch 8c82c52
Changed flow from triggerValidatorsExit to requestWithdrawal
eladiosch 8926347
Added fee to PufferProtocol.requestWithdrawal
eladiosch 7000731
Refactored fee return to modifier
eladiosch 01ba5b2
Implemented consolidation flow
eladiosch acd617c
Changed withdrawal credentials to type 2
eladiosch d6d18be
Changed callStake to deposit directly to beacon chain contract
eladiosch a64a585
validator tickets -> validation time
bxmmm1 3d7aaae
Added relation pubkey => module+index in storage
eladiosch 8937e08
provision flow (WIP)
eladiosch 3d35d5f
forge fmt
eladiosch b7e7d56
Removed return excess fee flow
eladiosch 199b7d2
Use moduleName + indices in withdrawal and consolidation flows
eladiosch b0e59aa
Implemented upgrading validators to type2 in PMM
eladiosch cb996fa
forge fmt
eladiosch 4ae75c3
Added accounting to consolidation flow
eladiosch 7f0f5c2
update natspec, remove buggy code
bxmmm1 8bb6958
Adapted requestWithdrawal and batchHandleWithdrawals
eladiosch aeed0e2
Adapted some comments and updated ValidatorKeyData
eladiosch 717a387
Fixed oracle call
eladiosch d162236
Adapted tests and refactor batchHandleWithdrawals
eladiosch 5f3132e
Spell error
eladiosch 8d365bd
Set PufferProtocol as payable to fix provisionNode
eladiosch d7ccb26
Removed placeholder value from Oracle
eladiosch 28790a0
Fixed failing tests + writing new ones
eladiosch a76adec
forge fmt
eladiosch 7883612
Added signature check to downsize, and changed burn. Restored old oracle
eladiosch 141628f
forge fmt
eladiosch 40b352c
Added numBatches to ValidatorKeyRegistered event
eladiosch c6cbc18
forge fmt
eladiosch 7b29240
resolve conflicts + minor changes
bxmmm1 efb9440
fix validator exits
bxmmm1 9c42d19
update the test
bxmmm1 5a9bd38
codespell
bxmmm1 e2158ec
Merge pull request #116 from PufferFinance/feature/remove-vt
eladiosch 1fca25b
Improved IProtocol natspec and naming. Slight optimization in protocol
eladiosch 8282259
Added comments and small refactor
eladiosch 95811ed
forge fmt
eladiosch e8cc1a9
Removed duplicated code
eladiosch c1cdf1e
Fixed wrong comment
eladiosch 991d558
Added numBatches param to relevant events
eladiosch 1f36dca
FIxed param bug in _getVTBurnAmount, added checks to _useVTOrValidati…
eladiosch 079872a
Removed min amount from _getVTBurnAmount
eladiosch 09690ce
Reworked signatures (tests not adapted)
eladiosch 9b62be5
Adapted one script and test handler
eladiosch 6b187f7
Adapted tests to new func sigs
eladiosch 899b73e
Refactors to fix stack too deep
eladiosch f392b1b
fmt
eladiosch a71569f
Added min and max for depositVT. Added numBatches when needed
eladiosch 86afa4b
Removed unused function
eladiosch 202c7f1
Created PufferLogic contract and adapted existing ones (WIP)
eladiosch 0b4a2b8
Adapted previous tests and improved signatures
eladiosch 37fff25
Changed ProtocolLogic structure. Moved more logic to ext contract (WIP)
eladiosch 27dea10
Fixed and simplify delegatecalls
eladiosch 50536f7
Refactor delegatecalls and small fixes
eladiosch 7b53076
Refactor PufferConstants to PufferProtocolBase and moved more logic t…
eladiosch ec3e5fe
forge fmt
eladiosch 9d2251f
Removed flow to deposit VT with Permit
eladiosch c104f39
Added tests to increase coverage
eladiosch 48c5b53
forge fmt
eladiosch 4e44801
Refactored interfaces and adapted tests (protocol WIP)
eladiosch eab8cfc
Changed approach of the delegatecall to logic contract
eladiosch 495ac9d
Removed selector constants
eladiosch bf0c713
Added some natspec to the fallback function
eladiosch a19d9a0
Moved logic from GuardianModule to Protocol to avoid re-deploying con…
eladiosch 5501856
forge fmt
eladiosch f3dafab
Added basic checks to withdrawValidationTime and added missing natspec
eladiosch 8d546b1
forge fmt
eladiosch 522f503
Update mainnet-contracts/src/PufferProtocol.sol
eladiosch e7fb64e
Update mainnet-contracts/src/PufferProtocol.sol
eladiosch 76a3233
Update mainnet-contracts/src/PufferProtocol.sol
eladiosch c90f5da
Update mainnet-contracts/src/PufferProtocol.sol
eladiosch e181e10
Update mainnet-contracts/src/PufferProtocolLogic.sol
eladiosch fad967d
Update mainnet-contracts/src/PufferProtocol.sol
eladiosch b982b2e
Using modifier (with require) to check deadlines
eladiosch 3c16eb3
Changed reverts to require and refactored to avoid stack too deep
eladiosch 3599a63
Added restricted for the Logic contract and improved natspec
eladiosch 59f2899
Merge pull request #119 from PufferFinance/external-protocol-logic
eladiosch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% sure that this was only used by the enclave, We can remove this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed