Fix #1964: lines_before_import sometimes ignored
#1965
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timothycrosley this is ready for review. It'd be great if this could be discussed and resolved before it starts lacking behind even more. |
|
@robsdedude Are you still interested in pursuing this? We could rebase this and get this reviewed :) |
|
Hi @DanielNoord, yes please. I've been patiently waiting for a review :) I've merged main into the PR so it's ready for a review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 40 40
Lines 3105 3106 +1
Branches 681 681
=======================================
+ Hits 3080 3081 +1
Misses 14 14
Partials 11 11 🚀 New features to boost your workflow:
|
DanielNoord
reviewed
Oct 5, 2025
DanielNoord
approved these changes
Oct 5, 2025
|
@robsdedude Since we use the merge queue I can't squash your commits myself. Could you perhaps squash the commits so I can merge this into |
The config option `lines_before_import` was ignored if the file only contained imports + optionally a leading comment.
robsdedude
force-pushed
the
fix/lbi-empty-only-import-files
branch
from
e39c314 to
043261f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config option
lines_before_importwas ignored if the file only containedimports + optionally a leading comment.
Fixes #1964