-
-
Notifications
You must be signed in to change notification settings - Fork 614
Feature/fix issue 1959 - Publish an official isort Docker image #2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bengt
wants to merge
5
commits into
PyCQA:main
Choose a base branch
from
Bengt:feature/fix-issue-1959
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4d34ea6
Package isort as a minimal, staged Docker image based on Python Alpine
Bengt c2e9c2f
Simplify and rebuild Docker ignores for the new Docker image
Bengt fea2a98
Extend the release workflow to building and pushing a Docker image
Bengt 44cb6f6
Document Docker image usage on the command line and in GitLab CICD
Bengt 6e55dde
Tag the latest image on various degrees of specicifity
Bengt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,7 @@ | ||
# project build medadata that can't be used in docker | ||
Dockerfile | ||
.appveyor.yml | ||
.dockerignore | ||
.pre-commit-hooks.yaml | ||
.travis.yml | ||
.git* | ||
# Ignore everything ... | ||
* | ||
|
||
# documentation not needed | ||
CHANGELOG.md | ||
LICENSE | ||
MANIFEST.in | ||
.undertake | ||
example.gif | ||
logo.png | ||
art/ | ||
docs/ | ||
# ... except: | ||
!isort | ||
!pyproject.toml | ||
!README.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,20 @@ | ||
FROM python:3.13 | ||
# Build stage | ||
FROM python:3.13-alpine AS builder | ||
|
||
WORKDIR /isort | ||
COPY pyproject.toml uv.lock /isort/ | ||
COPY . . | ||
|
||
# Install uv | ||
COPY --from=ghcr.io/astral-sh/uv:0.6.0 /uv /uvx /bin/ | ||
RUN pip install --no-cache-dir uv | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not copy from |
||
|
||
# Setup as minimal a stub project as possible, simply to allow caching base dependencies | ||
# between builds. | ||
# | ||
# If error is encountered in these steps, can safely be removed locally. | ||
RUN mkdir -p /isort/isort | ||
RUN mkdir -p /isort/tests | ||
RUN touch /isort/isort/__init__.py | ||
RUN touch /isort/tests/__init__.py | ||
RUN touch /isort/README.md | ||
COPY . /isort | ||
RUN SETUPTOOLS_SCM_PRETEND_VERSION=0.0.0 uv sync --all-extras --frozen | ||
RUN SETUPTOOLS_SCM_PRETEND_VERSION=0.0.0 uv build . | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be a different version? |
||
|
||
# Install latest code for actual project | ||
RUN rm -rf /isort | ||
# Release stage | ||
FROM python:3.13-alpine | ||
|
||
# Run full test suite | ||
CMD /isort/scripts/test.sh | ||
# Install the wheel from the build stage | ||
COPY --from=builder /isort/dist/ /tmp/ | ||
RUN \ | ||
pip install --no-cache-dir /tmp/*.whl && \ | ||
rm /tmp/*.whl | ||
|
||
ENTRYPOINT ["isort"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I have no clue what I'm looking at here. Is there perhaps a link you can share with some example of another project that has a similar setup?