Skip to content

Add useful error message for missing highspy. Allow variable objective #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add useful error message for missing highspy. Allow variable objective #453

wants to merge 9 commits into from
+42 −2

Conversation

RobbieKiwi
Copy link
Contributor

Closes #452.

Changes proposed in this Pull Request

-Add useful warning when using cbc without highspy installed
-Allow variable to be passed to objective

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

lkstrp
lkstrp approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Just add a very small test. Thank you @RobbieKiwi !

@RobbieKiwi
Copy link
Contributor Author

Is anybody good at monkeypatching?
In order to test the behaviour when highs is not installed I monkepatch "available_solvers" which is a global list imported by by model.py, but for the monkeypatch to work I have to re-import the Model class, and that somehow breaks all the tests in test_variable.py that rely on a pytest fixture that returns a model

FabianHofmann
FabianHofmann approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you @RobbieKiwi

@RobbieKiwi RobbieKiwi closed this Jun 11, 2025
@FabianHofmann
Copy link
Collaborator

@RobbieKiwi any reason to close this pr? it seemed to be quite well fixing the bug you reported

@FabianHofmann FabianHofmann reopened this Jun 18, 2025
@RobbieKiwi
Copy link
Contributor Author

@RobbieKiwi any reason to close this pr? it seemed to be quite well fixing the bug you reported

I tried to make a unittest to check that a warning was raised if the library is not installed in order to satisfy code coverage.
I couldn't work out how to get the unit test working. I tried using monkeypatch to pretend that a library is/isn't installed but it created problems for subsequent unittests that depend on the library.

I feel like it is not a super critical feature and maybe a test is not required so maybe you could override the codecoverage check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianHofmann FabianHofmann FabianHofmann approved these changes

@lkstrp lkstrp lkstrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vague warning for cbc highs dependency. Cannot have Variable objective
3 participants
@RobbieKiwi @FabianHofmann @lkstrp