Skip to content

Families module and test system big refactor #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2025
Merged

Families module and test system big refactor #21

merged 6 commits into from
Nov 4, 2025

Conversation

@LeonidElkin
Copy link
Collaborator

@LeonidElkin LeonidElkin commented Oct 11, 2025

  • ParametrizationSpec completely deleted. Now everything works via ParametricFamily
  • Improved work with decorators. Add a few more features like <fam_obj_name>.parametrization(...)
  • Now if you want your parametrization, you must inherit Parametrization class
  • Tests have been structured to directories and refactored to class-specific view
  • Mypy now checks tests with weaker ruleset, but still need lots of #type ...
  • Test directory now also a python module to simplify work with imports

@LeonidElkin LeonidElkin requested a review from Desiment October 11, 2025 20:45
Desiment
Desiment requested changes Oct 13, 2025
View reviewed changes
@LeonidElkin
# This is a combination of 2 commits.
8b3c27b 
# This is the 1st commit message:

refactor: delete ParametrizationSpec

# The commit message #2 will be skipped:

# fixup! refactor: delete ParametrizationSpec
@LeonidElkin
refactor: analytical computations build optimization
10139fb
@LeonidElkin
refactor: big refactor of test system
b21312a
@LeonidElkin
refactor: now mypy checks tests
4e0f373
@LeonidElkin LeonidElkin force-pushed the refactor/families-and-tests branch from 626b2c6 to 67f02ee Compare October 13, 2025 16:23
@LeonidElkin LeonidElkin requested a review from Desiment October 26, 2025 15:12
@LeonidElkin LeonidElkin force-pushed the refactor/families-and-tests branch from 67f02ee to 764993b Compare October 26, 2025 15:14
@LeonidElkin LeonidElkin force-pushed the refactor/families-and-tests branch from 764993b to bc851e1 Compare October 26, 2025 15:16
@LeonidElkin LeonidElkin marked this pull request as ready for review November 4, 2025 20:26
@LeonidElkin LeonidElkin merged commit cf5af0f into main Nov 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Desiment Desiment Desiment approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeonidElkin @Desiment