-
-
Notifications
You must be signed in to change notification settings - Fork 477
feat: ✨ Parse data as message in parse_message_update
instead of using _update
#2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paillat-dev
wants to merge
5
commits into
Pycord-Development:master
Choose a base branch
from
Paillat-dev:feat/mssage-update-parse-message
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: ✨ Parse data as message in parse_message_update
instead of using _update
#2780
Paillat-dev
wants to merge
5
commits into
Pycord-Development:master
from
Paillat-dev:feat/mssage-update-parse-message
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
VincentRPS
suggested changes
May 22, 2025
Signed-off-by: Paillat <me@paillat.dev>
Lulalaby
approved these changes
Aug 2, 2025
Lulalaby
reviewed
Aug 2, 2025
else: | ||
if poll_data := data.get("poll"): | ||
self.store_raw_poll(poll_data, raw) | ||
self.dispatch("raw_message_edit", raw) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that intented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I moved it up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Superseeds: #2778 - no need to merge both.
Fixes #2777
Message update contains a full message object - no need to use that messy update logic. See:
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.