Refactor tests to remove the embedded git #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
requested changes
Aug 7, 2025
|
I've thought of one possible improvement, but this is already a big enough PR so it could be done separately. Rather than use the hardcoded path Line 7 in 94b9870 Then each test will definitely be isolated from the other tests (each will have its own working_dir), and we won't have to cleanup after each test (e.g. removing the cloned xtl repo) as the temporary directories will automatically be cleaned for us.
Also I will create an issue for checking the |
ianthomas23
reviewed
Aug 7, 2025
test/test_branch.py
Outdated
| p = subprocess.run(cmd, capture_output=True, cwd="test/data/status_data", text=True) | ||
| assert(p.stdout == '* main\n') | ||
| p = subprocess.run(cmd, capture_output=True, cwd=working_dir, text=True) | ||
| print() |
There was a problem hiding this comment.
Ooh, empty print statement. I assume it isn't needed?
There was a problem hiding this comment.
I always forget a print left in my code somewhere...
There was a problem hiding this comment.
At least there were no swear words in it!
|
I'll change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests to remove the embedded git