External dependencies management #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hind-M
reviewed
Jul 25, 2025
Comment on lines
+31
to
+33
| - name: Install external dependencies | ||
| run: micromamba install -n build_env -y -f ./environment-dev.yml | ||
|
|
There was a problem hiding this comment.
This is redundant and should be completely removed.
.github/workflows/osx.yml
Outdated
Comment on lines
31
to
33
| - name: Install external dependencies | ||
| run: micromamba install -n build_env -y -f ./environment-dev.yml | ||
|
|
.github/workflows/windows.yml
Outdated
Comment on lines
33
to
35
| - name: Install external dependencies | ||
| run: micromamba install -n build_env -y -f ./environment-dev.yml | ||
|
|
| - name: Build sparrow-ipc | ||
| run: | | ||
| cmake -B build/ -G Ninja \ | ||
| -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \ | ||
| -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX \ | ||
| -DCMAKE_PREFIX_PATH=$CONDA_PREFIX \ |
Alex-PLACET
force-pushed
the
external_dependencies_management
branch
from
e6a69d9 to
1bf99a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.