Skip to content

Implement electron-nuclear spin register for MBQC distillation protocol #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement electron-nuclear spin register for MBQC distillation protocol #285

wants to merge 4 commits into from

Conversation

@hanakl
Copy link
Contributor

@hanakl hanakl commented Oct 7, 2025

For issue #204

@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.36%. Comparing base (2d40bb7) to head (feac4b0).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   69.36%   69.36%           
=======================================
  Files          57       57           
  Lines        2357     2357           
=======================================
  Hits         1635     1635           
  Misses        722      722

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Benchmark Result

Judge result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmarks:
  • Target: 7 Oct 2025 - 03:12
  • Baseline: 7 Oct 2025 - 03:14
  • Package commits:
  • Julia commits:
  • Target: f2b3dbd
  • Baseline: f2b3dbd
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Brackets display tolerances for the benchmark estimates. Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["tagquery", "messagebuffer", "querydelete"] 0.90 (5%) ✅ 1.00 (1%)
["tagquery", "register", "queryall"] 0.98 (5%) 0.95 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["quantumstates", "observable"]
  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Target

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.3 LTS
 uname: Linux 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 0 MHz 4115 s 0 s 246 s 2623 s 0 s
 #2 0 MHz 4780 s 0 s 248 s 1974 s 0 s
 #3 0 MHz 4194 s 0 s 215 s 2591 s 0 s
 #4 0 MHz 4546 s 0 s 253 s 2190 s 0 s
 Memory: 15.620681762695312 GB (13282.23046875 MB free)
 Uptime: 702.58 sec
 Load Avg: 1.1 2.49 1.79
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.3 LTS
 uname: Linux 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 0 MHz 4524 s 0 s 264 s 3146 s 0 s
 #2 0 MHz 5244 s 0 s 276 s 2432 s 0 s
 #3 0 MHz 4214 s 0 s 217 s 3520 s 0 s
 #4 0 MHz 4564 s 0 s 254 s 3121 s 0 s
 Memory: 15.620681762695312 GB (13110.39453125 MB free)
 Uptime: 797.75 sec
 Load Avg: 1.02 2.08 1.71
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmark: 7 Oct 2025 - 03:12
  • Package commit: 5f814bd
  • Julia commit: f2b3dbd
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["quantumstates", "observable", "quantumoptics"] 701.000 ns (5%) 2.28 KiB (1%) 17
["register", "creation_and_initialization", "from_tests"] 200.193 μs (5%) 973.89 KiB (1%) 2574
["tagquery", "messagebuffer", "query"] 360.707 ns (5%) 64 bytes (1%) 2
["tagquery", "messagebuffer", "querydelete"] 771.000 ns (5%) 96 bytes (1%) 3
["tagquery", "misc", "from_tests"] 8.188 μs (5%) 15.25 KiB (1%) 185
["tagquery", "register", "query"] 3.901 s (5%) 2.440 s 604.79 MiB (1%) 5025645
["tagquery", "register", "queryall"] 4.112 s (5%) 2.517 s 1.50 GiB (1%) 4024144

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["quantumstates", "observable"]
  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.3 LTS
 uname: Linux 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 0 MHz 4115 s 0 s 246 s 2623 s 0 s
 #2 0 MHz 4780 s 0 s 248 s 1974 s 0 s
 #3 0 MHz 4194 s 0 s 215 s 2591 s 0 s
 #4 0 MHz 4546 s 0 s 253 s 2190 s 0 s
 Memory: 15.620681762695312 GB (13282.23046875 MB free)
 Uptime: 702.58 sec
 Load Avg: 1.1 2.49 1.79
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmark: 7 Oct 2025 - 03:14
  • Package commit: 2d40bb7
  • Julia commit: f2b3dbd
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["quantumstates", "observable", "quantumoptics"] 711.000 ns (5%) 2.28 KiB (1%) 17
["register", "creation_and_initialization", "from_tests"] 197.188 μs (5%) 973.89 KiB (1%) 2574
["tagquery", "messagebuffer", "query"] 359.541 ns (5%) 64 bytes (1%) 2
["tagquery", "messagebuffer", "querydelete"] 852.000 ns (5%) 96 bytes (1%) 3
["tagquery", "misc", "from_tests"] 8.182 μs (5%) 15.25 KiB (1%) 185
["tagquery", "register", "query"] 3.755 s (5%) 2.313 s 607.23 MiB (1%) 5045645
["tagquery", "register", "queryall"] 4.179 s (5%) 2.450 s 1.58 GiB (1%) 4234144

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["quantumstates", "observable"]
  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.3 LTS
 uname: Linux 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 0 MHz 4524 s 0 s 264 s 3146 s 0 s
 #2 0 MHz 5244 s 0 s 276 s 2432 s 0 s
 #3 0 MHz 4214 s 0 s 217 s 3520 s 0 s
 #4 0 MHz 4564 s 0 s 254 s 3121 s 0 s
 Memory: 15.620681762695312 GB (13110.39453125 MB free)
 Uptime: 797.75 sec
 Load Avg: 1.02 2.08 1.71
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.84
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves user_shstk clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Krastanov
Krastanov reviewed Oct 7, 2025
View reviewed changes
examples/purificationMBQC/electron_nuclear_spin_register.jl Outdated
Comment on lines 47 to 53
function graph_generator(initial_entanglements_nodes, purified_nodes)
g = Graph(4)
for ij in [(1,3), (2,3), (3,4)]
add_edge!(g, ij...)
end
return g
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this to purification_resource_graph(code) or something like this

Krastanov
Krastanov reviewed Oct 7, 2025
View reviewed changes
examples/purificationMBQC/electron_nuclear_spin_register.jl Outdated
end

# TODO: right now, it just measures all but purified nodes
@resumable function measure(sim, net, side, purified_nodes, storage_slot)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's avoid assuming that this will be the only protocol running (e.g. the way you do index arithmetics with n depends on the assumption you have only two groups of nodes, only dedicated to running this protocol)

maybe;

function measure(sim, net, local_storage_nodes_idx, storage_slot, remote_chief_node_idx)

Krastanov
Krastanov reviewed Oct 7, 2025
View reviewed changes
examples/purificationMBQC/electron_nuclear_spin_register.jl Outdated
if !(node in local_purified_nodes)
reg = net[node]
m = project_traceout!(reg[storage_slot], X) # TODO: fixed basis for now
tag!(reg[storage_slot], MBQCMeasurement, node, m) # storing the results for now, in case we need to something more sophisticated with them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not tag this until we know we actually need this tag

Krastanov
Krastanov reviewed Oct 7, 2025
View reviewed changes
examples/purificationMBQC/electron_nuclear_spin_register.jl Outdated
# TODO: send the entangler fusion measurement info as well..
end

@resumable function purification_tracker(sim, net, side, purified_nodes, storage_slot)
Copy link
Member

@Krastanov Krastanov Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same restructuring as above, presumably just purification_tracker(sim, net, local_chief_node_idx, local_purified_nodes_idx, storage_slot)

Krastanov
Krastanov reviewed Oct 7, 2025
View reviewed changes
examples/purificationMBQC/electron_nuclear_spin_register.jl
tag!(local_tag.slot, PurifiedEntalgementCounterpart, src_node, storage_slot)
else
@debug "Purification failed."
untag!(local_tag.slot, local_tag.id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and delete that qubit

Krastanov
Krastanov reviewed Oct 7, 2025
View reviewed changes
examples/purificationMBQC/electron_nuclear_spin_register.jl



@resumable function entangler_fusion(sim, net, nodeA, nodeB, communication_slot, storage_slot, pairstate)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@resumable function entangler_fusion(sim, net, nodeA, nodeB, communication_slot, storage_slot, pairstate)
@resumable function entangler_fusion(sim, net, nodeA, nodeB, communication_slot, storage_slot, pairstate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Krastanov Krastanov Krastanov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanakl @Krastanov