Several adjustments/fixes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use .fcXX directly, instead of %{?dist}, as the latter may have "devel"
build number added by the qubes-builder.
Append .fcXX to XEN_VERSION/LINUX_VERSION directly.
This avoids repeating the same pattern over and over.
Since actual pesign is called via socket/qrexec, it isn't really a direct build dependency - remove it.
Wrap long lines to ease reading. No functional change.
socat has 0.5s timeout by default, which means it will exit after 0.5s since finishing sending the data. When signing with a HVM, this is too little and exits before receiving signed file. Increase the timeout to 30s.
socat (and socket forwarding in general) does not carry over qrexec service exit code. The service is written in a way to not output anything if signing fails, so simply check for non-emptiness of the result. QubesOS/qubes-issues#8206
Perviously, only unsigned file was packages, even though signed one was next to it. Package the signed one instead. QubesOS/qubes-issues#8206
It makes more sense there. This includes also removing qubes-pesign.service from here, and converting it to systemd socket service while moving. QubesOS/qubes-issues#8206
|
PipelineRetry |
Testing reproducibility doesn't make much sense here, as reproducing the package requires access to the signing key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.