refactor(insight): split DataProcessor into focused single-responsibi…#2269
Open
wenshao wants to merge 1 commit intoQwenLM:mainfrom
Open
refactor(insight): split DataProcessor into focused single-responsibi…#2269wenshao wants to merge 1 commit intoQwenLM:mainfrom
wenshao wants to merge 1 commit intoQwenLM:mainfrom
Conversation
…lity classes The 1131-line DataProcessor class handled four distinct concerns: metrics calculation, LLM session analysis, qualitative insight generation, and orchestration. This splits it into: - MetricsCalculator (269 lines): heatmaps, streaks, tool usage, durations - SessionAnalyzer (388 lines): LLM-based session facet analysis and aggregation - QualitativeInsightGenerator (407 lines): 8 parallel LLM insight calls - DataProcessor (144 lines): slim orchestrator delegating to the above Tests updated to test each class directly (no more private method casts). All 35 existing tests pass unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wenshao
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lity classes
The 1131-line DataProcessor class handled four distinct concerns: metrics calculation, LLM session analysis, qualitative insight generation, and orchestration. This splits it into:
Tests updated to test each class directly (no more private method casts). All 35 existing tests pass unchanged.
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs