fix(core): guard against empty choices in convertOpenAIResponseToGemini#2364
Open
netbrah wants to merge 1 commit intoQwenLM:mainfrom
Open
fix(core): guard against empty choices in convertOpenAIResponseToGemini#2364netbrah wants to merge 1 commit intoQwenLM:mainfrom
netbrah wants to merge 1 commit intoQwenLM:mainfrom
Conversation
The streaming path (convertOpenAIChunkToGemini) already uses optional chaining on choices and guards with `if (choice)`, but the non-streaming path accesses choices[0] directly. Providers that return an empty choices array cause a TypeError crash. Made-with: Cursor
netbrah
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertOpenAIResponseToGeminiaccesseschoices[0]without a guard, crashing withTypeErrorwhen a provider returns an emptychoicesarray. The streaming counterpart (convertOpenAIChunkToGemini) already useschoices?.[0]with anif (choice)guard — this fix applies the same pattern to the non-streaming path.Fix
choices?.[0]choiceis falsyTest
Added test: empty
choicesarray returns a response withcandidates: []instead of crashing.Made with Cursor