Shooter #4
Shooter #4
Conversation
I don't actually really know what the actual specs of the shooter are. This was mostly made as a tutorial to git for the rest of the SPEC team.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import com.ctre.phoenix.motorcontrol.NeutralMode; | ||
| import com.ctre.phoenix.motorcontrol.can.TalonFX; | ||
|
|
||
| import frc.robot.logging.Loggable; |
There was a problem hiding this comment.
Extra separation in import group before 'frc.robot.logging.Loggable'
src/main/java/frc/robot/Shooter.java
Outdated
|
|
||
| public class Shooter implements Loggable { | ||
| TalonFX shooterMotor; | ||
| public Shooter(TalonFX s) { |
There was a problem hiding this comment.
'CTOR_DEF' should be separated from previous statement.
src/main/java/frc/robot/Shooter.java
Outdated
|
|
||
| public class Shooter implements Loggable { | ||
| TalonFX shooterMotor; | ||
| public Shooter(TalonFX s) { |
There was a problem hiding this comment.
Parameter name 's' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
src/main/java/frc/robot/Shooter.java
Outdated
|
|
||
| public class Shooter implements Loggable { | ||
| TalonFX shooterMotor; | ||
| public Shooter(TalonFX s) { |
There was a problem hiding this comment.
'CTOR_DEF' should be separated from previous line.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
============================================
- Coverage 17.78% 16.83% -0.96%
Complexity 17 17
============================================
Files 13 14 +1
Lines 371 392 +21
Branches 25 27 +2
============================================
Hits 66 66
- Misses 305 326 +21
|
| import com.ctre.phoenix.motorcontrol.NeutralMode; | ||
| import com.ctre.phoenix.motorcontrol.can.TalonFX; | ||
|
|
||
| import frc.robot.logging.Loggable; |
There was a problem hiding this comment.
Import statement for 'frc.robot.logging.Loggable' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.
| import com.ctre.phoenix.motorcontrol.can.TalonFX; | ||
|
|
||
| import frc.robot.logging.Loggable; | ||
| import frc.robot.logging.Logger; |
There was a problem hiding this comment.
Import statement for 'frc.robot.logging.Logger' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.
|
|
||
| public class Shooter implements Loggable { | ||
| TalonFX shooterMotor; | ||
| public Shooter(int shooterID) { |
There was a problem hiding this comment.
'CTOR_DEF' should be separated from previous statement.
|
Code Climate has analyzed commit 1a46ce6 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 16.8% (-0.8% change). View more on Code Climate. |
No description provided.