Correct handling of non-existent stores in open is unclear #1575
mwatts15
started this conversation in
Documentation
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The doc-comment for Store.open indicates the following (my emphasis):
However, an exception is not raised by the sleepycat store, the only store in the standard library for which the create flag is meaningful. For sleepycat, in the case that create=False and no store already exists it returns rdflib.store.NO_STORE. In addition in the same doc comment it's indicated that NO_STORE is a valid return value from Store.open, but there's no indication of when that should be returned, nor is there any code which expects NO_STORE (or any of the related constants) by name.
It should be made clear what the appropriate action is for a store when create is False, but the indicated store does not exist.
Beta Was this translation helpful? Give feedback.
All reactions