Skip to content

[kilted] Update deprecated call to ament_target_dependencies #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

[kilted] Update deprecated call to ament_target_dependencies #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dynamixel_workbench_toolbox/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ add_library(${LIB_NAME} SHARED
src/${PROJECT_NAME}/dynamixel_tool.cpp
src/${PROJECT_NAME}/dynamixel_workbench.cpp
)
ament_target_dependencies(${LIB_NAME} ${dependencies_lib})
target_link_libraries(${LIB_NAME} PUBLIC ${dependencies_lib})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a comment explaining why this change was made, referencing the ROS 2 Kilted release notes. This will help future developers understand the context of the change.

target_link_libraries(${LIB_NAME} PUBLIC ${dependencies_lib}) # Updated for ROS 2 Kilted: ament_target_dependencies is deprecated


################################################################################
# Install
Expand Down