Almost completely re-written to build images with docker-compose #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All images are built with docker-compose.
* Reuse pre-built image to reduce time and space.
* Re-wrote `docker-compose.yml`
* Remove (probably) obsolete services for building images from souce.
* Only a specific OS version is teated at a time.
* OS / version / variant are specified by `.env` file.
* `render` group id is set to same number as host.
* Use `gpg --dearmor` instead of `apt-key add` for ubuntu-20.04.
|
Need documents update if this patch will be applied. |
* Add image variants based on newer ROCm meta-packages * Omit CentOS-7 stuff
* Add Ubuntu 22.04 stuffs.
* Add `/etc/apt/preferences.d/90-rocm-jammy` to give higer priority
to ROCm packages, since Ubuntu 22.04 already has ROCm related
packages on universe archive.
* Change url for ROCm packages.
|
I updated my git tree:
|
Remove DBUS_SESSION_BUS_ADDRESS environment from docker-compose.yaml
Update default to ROCm 5.6
aimoff
requested review from
amd-aakash,
kiran-thumma,
okakarpa and
sunway513
as code owners
* Update default to Ubuntu 22.04 and ROCm 5.4 * Drop Ubuntu 18.04 stuffs * Drop hip-libs and opencl-ml variants * Change default flavor for xterm
* Add Ubuntu 24.04 stuffs * Update default to Ubuntu 24.04 and ROCm 6.2 * Add USER_NAME argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose.yml.envfile.rendergroup id is set to same number as host.gpg --dearmorinstead ofapt-key addfor ubuntu-20.04.