merge main into amd-staging #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…159984) Before this PR, `FilesToRemove` was constructed but never deleted.
Fix out of buffer read when value of --type-index was too big Co-authored-by: Alexandre Ganea <aganea@havenstudios.com>
Identified with modernize-use-equals-default.
In C++17, static constexpr members are implicitly inline, so they no longer require an out-of-line definition. Identified with readability-redundant-declaration.
In C++17, static constexpr members are implicitly inline, so they no longer require an out-of-line definition. This patch also removes redundant "const" from the in-class definitions. Identified with readability-redundant-declaration.
Before this PR, `clang --print-runtime-dir` on Windows used to report a non-existent directory if `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF`. We now check if any of the known runtime directories exist before printing any of them on stdout. If none exists, we print `(runtime dir is not present)`.
…cape paths (llvm#103397) If any of the printed paths by llvm-config contain quotes, spaces, backslashes or dollar sign characters, these paths will be quoted and escaped, but only if using `--quote-paths`. The previous behavior is retained for compatibility and `--quote-paths` is there to acknowledge the migration to the new behavior. Following discussion in llvm#76304 Fixes llvm#28117 Superseeds llvm#97305 I could also do what @tothambrus11 suggests in llvm#97305 (comment) but that makes all Windows paths quoted & escaped since they all contain backslashes.
This patch introduces StringSetTag, a dedicated empty struct to serve as the "value type" for llvm::StringSet. This change is part of an effort to reduce the use of std::nullopt_t outside the context of std::optional.
…ion (llvm#164660) We typically shouldn't get this, but when we do (e.g. in llvm#139439) we should error out gracefully instead of crashing. Note that we are stricter than ld64 here; ld64 appears to be able to handle section offsets that point outside literal sections if the end result is a valid pointer to another section in the input object file. Supporting this would probably be a pain given our current design, and it seems like enough of an edge case that it's onot worth it.
…#164540) Fixes a typo in the include guard name in hlsl_compat_overloads.h The incorrect line: ` #define _HLSl_COMPAT_OVERLOADS_H_` has been corrected to: ` #define _HLSL_COMPAT_OVERLOADS_H_` Fixes llvm#164100
This is a follow-up for llvm#103397
This fixes: ``` [3902/4335] Building CXX object tools\lld\MachO\CMakeFiles\lldMachO.dir\Arch\X86_64.cpp.obj C:\git\llvm-project\lld\MachO\Arch\X86_64.cpp(107): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) ```
ronlieb
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.