Enable LDSBankConflict pmc on gfx942 #2005
Open
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez0
reviewed
Sep 30, 2025
dhernandez0
reviewed
Oct 2, 2025
mlir/utils/performance/perfRunner.py
Outdated
|
|
||
| def getProfilerOutputPath(arch: str, baseOutPath): | ||
| chip = GFX_CHIP_RE.search(arch).group(0) | ||
| # TODO (gfx950): check if gfx950 need this |
There was a problem hiding this comment.
please, can you remove the TODO?
dhernandez0
reviewed
Oct 2, 2025
mlir/utils/performance/perfRunner.py
Outdated
| current_dir = os.path.dirname(os.path.abspath(__file__)) | ||
| metrics_path = os.path.join(current_dir, ROCMLIR_INPUT_METRICS_FILE_NAME) | ||
| metrics = [] | ||
| # TODO (gfx950): check if gfx950 supports this |
dhernandez0
approved these changes
Oct 7, 2025
umangyadav
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
close: https://github.com/ROCm/rocMLIR-internal/issues/1929
Technical Details
This PR enables the LDSBankConflict counter on gfx942, as it was added to rocprof after ROCm 7.0.
There is still no counters for gfx950.
Test Plan
CI tests