Skip to content

Enable LDSBankConflict pmc on gfx942 #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Enable LDSBankConflict pmc on gfx942 #2005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cc0c59
Enable LDSBankConflict pmc on gfx942
djramic Sep 30, 2025
3d11fcc
Remove TODO
djramic Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlir/utils/performance/perfRunner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def getNanoSeconds(fileName):
def getProfilerOutputPath(arch: str, baseOutPath):
chip = GFX_CHIP_RE.search(arch).group(0)
# TODO (gfx950): check if gfx950 need this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, can you remove the TODO?

if(chip not in ["gfx942"]):
if(chip not in ["gfx950"]):
return os.path.join('pmc_1', baseOutPath)
return baseOutPath

Expand All @@ -222,7 +222,7 @@ def getMetricArgsForRocprof(arch: str):
metrics_path = os.path.join(current_dir, ROCMLIR_INPUT_METRICS_FILE_NAME)
metrics = []
# TODO (gfx950): check if gfx950 supports this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, remove TODO

if (chip not in ["gfx942"]):
if (chip not in ["gfx950"]):
metrics = ['-i', metrics_path]
return metrics

Expand Down