[rocSOLVER] Increase sygvdx inplace test tolerance#4436
Merged
AGonzales-amd merged 1 commit intodevelopfrom Feb 11, 2026
Merged
[rocSOLVER] Increase sygvdx inplace test tolerance#4436AGonzales-amd merged 1 commit intodevelopfrom
AGonzales-amd merged 1 commit intodevelopfrom
Conversation
EdDAzevedo
approved these changes
Feb 9, 2026
mgates3
approved these changes
Feb 9, 2026
jmachado-amd
approved these changes
Feb 9, 2026
john00003
approved these changes
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4436 +/- ##
========================================
Coverage 65.31% 65.31%
========================================
Files 1577 1577
Lines 242154 242154
Branches 33912 33912
========================================
Hits 158144 158144
Misses 70009 70009
Partials 14001 14001
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
tfalders
approved these changes
Feb 10, 2026
AGonzales-amd
deleted the
users/AGonzales-amd/rocsolver-sygvdx-inplace-tolerance
branch
assistant-librarian bot
pushed a commit
to ROCm/rocSOLVER
that referenced
this pull request
Feb 11, 2026
[rocSOLVER] Increase sygvdx inplace test tolerance ## Motivation Inplace sygvdx tests are failing due to tight test tolerances. (ROCM-562) ## Technical Details This PR increases the test tolerance for inplace sygvdx. ## Test Plan Test locally and validate with CI. ## Test Result Local tests of SYGVDX_INPLACE pass after fix. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation Inplace sygvdx tests are failing due to tight test tolerances. (ROCM-562) ## Technical Details This PR increases the test tolerance for inplace sygvdx. ## Test Plan Test locally and validate with CI. ## Test Result Local tests of SYGVDX_INPLACE pass after fix. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation Inplace sygvdx tests are failing due to tight test tolerances. (ROCM-562) ## Technical Details This PR increases the test tolerance for inplace sygvdx. ## Test Plan Test locally and validate with CI. ## Test Result Local tests of SYGVDX_INPLACE pass after fix. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Inplace sygvdx tests are failing due to tight test tolerances. (ROCM-562)
Technical Details
This PR increases the test tolerance for inplace sygvdx.
Test Plan
Test locally and validate with CI.
Test Result
Local tests of SYGVDX_INPLACE pass after fix.
Submission Checklist