Skip to content

Conversation

@Milacus
Copy link

@Milacus Milacus commented Sep 7, 2025

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Build process stability improvement

  • What is the current behavior?
    The TRANSLATION_DIR variable in the source/build.sh file will be a relative path to the location from where the script was called (which could be the root of the repository or anywhere in the system) which will cause the script to fail. To resolve the path correctly one must call the script from within the source/ directory

  • What is the new behavior (if this is a feature change)?
    Translation dir is now relative to the script directory (and not the location from where the script was called). This way one call call the build.sh script from the root of the repository and it still works.

- Translation dir is now relative to the script directory (and not the location from where the script was called)
@Ralim Ralim enabled auto-merge September 12, 2025 12:41
@Milacus
Copy link
Author

Milacus commented Sep 12, 2025

The build is successful when run with few enough cores or when every target is built sequentially. I think the build errors shows an issue within the Makefiles. I'll try to dig into it next week.

@Ralim Ralim disabled auto-merge September 12, 2025 22:53
@Milacus
Copy link
Author

Milacus commented Sep 12, 2025

Fixed the dependency declarations in the Makefile. The change is a bit bigger than I thought. Still think it would be nice but up to you how/ if you want to proceed with the changes.


EDIT: This does not fully cover the issue yet. I'll have to dig into it when I have some time.

@Milacus Milacus force-pushed the dev-update-build-script branch from 0df9444 to 6783e9a Compare September 12, 2025 22:58
@Ralim
Copy link
Owner

Ralim commented Sep 13, 2025

@Milacus I'm happy for this change. I've never run into this but its perfectly reasonable to me. LMK when your happy.

@Milacus
Copy link
Author

Milacus commented Sep 17, 2025

Sadly I did not get around to look into the issue and will be going on vacation tonight. I'll pick this up once I'm back. Sorry about the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants