Some build logs are still being swallowed (#504)

closes #503

---------

Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com>
Co-authored-by: Dan Halson <dan.halson@raspberrypi.org>

Author: create-issue-branch[bot]

.devcontainer/devcontainer.json

@@ -70,7 +70,13 @@
         "ninoseki.vscode-mogami"
       ],
       "settings": {
-        "terminal.integrated.defaultProfile.linux": "zsh"
+        "terminal.integrated.defaultProfile.linux": "zsh",
+        "editor.codeActionsOnSave": {
+          "source.fixAll": "explicit"
+        },
+        "rubyLsp.enabledFeatures": {
+          "diagnostics": true
+        }
       }
     }
   }

app/jobs/upload_job.rb

@@ -40,10 +40,6 @@ class UploadJob < ApplicationJob
   def perform(payload)
     modified_locales(payload).each do |locale|
       projects_data = load_projects_data(locale, repository(payload), owner(payload))
-      if projects_data.data.repository&.object.nil?
-        Rails.logger.warn 'Build skipped, does the repo exist?'
-        break
-      end
 
       projects_data.data.repository.object.entries.each do |project_dir|
         project = format_project(project_dir, locale, repository(payload), owner(payload))
@@ -80,28 +76,10 @@ def load_projects_data(locale, repository, owner)
   end
 
   def handle_graphql_errors(response)
-    errors = response&.errors.presence || response&.data&.errors
+    errors = response&.errors || response&.data&.errors
     return if errors.blank?
 
-    error_messages, error_details, error_type = extract_error_info(errors)
-
-    # Handle NOT_FOUND errors as a special case, as this can happen when the repo is first created
-    raise GraphQL::Client::Error, "GraphQL query failed with errors: #{error_messages}. Details: #{error_details}" unless error_type == 'NOT_FOUND'
-  end
-
-  def extract_error_info(errors)
-    error_type = nil
-    if errors.is_a?(Array) && errors.first.is_a?(Hash)
-      # Query level error
-      error_messages = errors.map { |error| error }
-      error_details = errors.map { |error| error }
-      error_type = error_details.dig(0, 1, 0, 'type')
-    else
-      # Top level error
-      error_messages = errors.messages['data'].first
-      error_details = errors.details['data'].first['message']
-    end
-    [error_messages, error_details, error_type]
+    raise GraphQL::Client::Error, "GraphQL query failed with errors: #{errors.inspect}"
   end
 
   def format_project(project_dir, locale, repository, owner)

spec/jobs/upload_job_spec.rb

@@ -206,4 +206,27 @@
       expect { described_class.perform_now(payload) }.to change(Project, :count).by(1)
     end
   end
+
+  context 'with a graphql error response' do
+    let(:raw_response) do
+      {
+        errors: [
+          {
+            'message' => 'Simulated INTERNAL_SERVER_ERROR message',
+            'locations' => [{ 'line' => 2, 'column' => 4 }],
+            'path' => %w[query repository object],
+            'extensions' => { 'code' => 'INTERNAL_SERVER_ERROR' }
+          }
+        ]
+      }
+    end
+
+    before do
+      stub_request(:post, 'https://api.github.com/graphql').to_return(status: 200, body: raw_response.to_json, headers: {})
+    end
+
+    it 'raises a GraphQL::Client::Error' do
+      expect { described_class.perform_now(payload) }.to raise_error(GraphQL::Client::Error, /Simulated INTERNAL_SERVER_ERROR message/)
+    end
+  end
 end