feat: Component to handle permissions request (A13+) #2710

brosssh · 2025-08-27T13:47:16Z

Starting from Android 13, notification permission is now not granted by default. With this motivation, I created a component to handle permission requests (PermissionRequestHandler). This will show a dialog with an explantion of why the permission is requested, and will allow the user to give or reject the permission. Currently this is just used for the notifications permission, but it's possible other permissions will be needed in the future.

I have also added a notification when the patching process is completed (both in case of success and failure).

brosssh · 2025-08-27T13:50:39Z

app/src/main/res/values/strings.xml

+    <string name="patcher_notification_running_title">Patching in progress…</string>
+    <string name="patcher_notification_running_text">Tap to return to the patcher</string>
+    <string name="patcher_notification_success_title">Patching completed</string>
+    <string name="patcher_notification_success_text">Patching completed! Tap to return to the patcher</string>
+    <string name="patcher_notification_failure_title">Failure while patching</string>
+    <string name="patcher_notification_failure_text">Patching completed with errors. Tap to return to the patcher</string>


My english sucks, please propose anything that works better in these strings.

Flutter manager might have similar strings. Otherwise, I can try and help you come up with strings later.

Axelen123

I don't know if permissions should be requested on app launch or in the patcher screen. This is up to the UI team to decide.

app/src/main/java/app/revanced/manager/patcher/worker/PatcherWorker.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt

app/src/main/java/app/revanced/manager/util/permissions/ContextExtension.kt

app/src/main/java/app/revanced/manager/util/permissions/Helper.kt

app/src/main/java/app/revanced/manager/patcher/worker/PatcherWorker.kt

Axelen123 · 2025-08-27T15:32:52Z

app/src/main/res/values/strings.xml

+    <string name="patcher_notification_running_title">Patching in progress…</string>
+    <string name="patcher_notification_running_text">Tap to return to the patcher</string>
+    <string name="patcher_notification_success_title">Patching completed</string>
+    <string name="patcher_notification_success_text">Patching completed! Tap to return to the patcher</string>
+    <string name="patcher_notification_failure_title">Failure while patching</string>
+    <string name="patcher_notification_failure_text">Patching completed with errors. Tap to return to the patcher</string>


Flutter manager might have similar strings. Otherwise, I can try and help you come up with strings later.

brosssh · 2025-08-27T15:52:18Z

I don't know if permissions should be requested on app launch or in the patcher screen. This is up to the UI team to decide.

My reasoning for putting the dialog in the patcher screen is that there is already a popup shown at app first launch (to configure updates). Once that is closed, there are two mores "alert", one for the battery optimization and one for the downloaders configuration.

I didn't want to add another dialog to not overwhelm the user; also the notification permission is striclty related to the patching process (for now at least). Of course, it can be changed according to what UI team thinks.

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt

app/src/main/java/app/revanced/manager/patcher/worker/PatcherWorker.kt

app/src/main/java/app/revanced/manager/util/permissions/ContextExtension.kt

app/src/main/java/app/revanced/manager/ui/viewmodel/PermissionViewModel.kt

app/src/main/java/app/revanced/manager/ui/screen/AppSelectorScreen.kt

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt

Axelen123 · 2025-09-05T17:54:11Z

app/src/main/java/app/revanced/manager/patcher/worker/PatcherWorker.kt

+                ("An exception occurred in the remote process while patching." +
+                        " ${e.originalStackTrace}").logFmt())


Is there a reason to split this?

Just to respect the right margin.

app/src/main/java/app/revanced/manager/patcher/worker/PatcherWorker.kt

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt

kitadai31 · 2025-09-06T20:14:00Z

The new "Patching completed" notification should not include Tap to return to the patcher sentence.
Because it will be displayed even when the patcher screen is open. This text was originally created for background running notifications. It's not necessary in the patching completion notification.
The new "Patching completed" notification is a bit annoying. What's particularly annoying is having to manually clear the notifications after every patching.
It would be convenient if notifications were automatically deleted upon leaving the patcher screen.

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt

MarcaDian · 2025-10-12T19:25:52Z

Hi. I see in your screenshot that there is a problem with the white ReVanced logo being displayed on a white background. I plan to fix this in #2762, can you please rebase this PR to the dev branch? Thanks

By the way, does this PR fix the lack of a notification icon in the status bar during patching?

Axelen123 and others added 30 commits May 20, 2025 14:01

fix: delete temporary files (ReVanced#1341)

ffe5c05

feat: use revanced api for changelogs

c2c4895

feat: add patches selector bottom sheet (ReVanced#1360)

e1742fd

feat: settings migration (compose) (ReVanced#1309)

cadbb3f

refactor(downloaders): improve file system code (ReVanced#1379)

80ff671

feat: armv7 warning

edb387e

feat: hide unfinished pages in release mode

99bfd84

fix: broken logo in about page on release builds

76e5731

chore: bump compose

977345e

chore: bump patcher

db04672

feat: add user agent (ReVanced#1382)

a159246

fix: hide patch button (ReVanced#1284)

88f3701

refactor: move mount code to when block

0e00b9f

feat: selected app info page (ReVanced#1395)

4ad3c3f

fix: use upsert when modifying installed apps

d8d2478

fix: jvm signature clash error

5907659

fix: bundles not loading on Android 14

ac75d1d

feat(patch-selector): remove TODO about an unplanned feature

991a8cb

fix: handle exceptions when checking for bundle updates

0cf4999

fix: more android 34 fixes

464aa75

feat: add checkboxes to the downloaded apps page

1de59f4

feat: show toast when no patches are selected

da41530

docs: clarify license

3f34407

feat(bundles tab): add BackHandler

691b615

fix: perform selected app operations in the correct order

d239efc

chore: upgrade dependencies (ReVanced#1401)

8450243

fix: use correct checksum

a35c62a

feat(installer): sign apk in patcher worker

ad10a19

chore: add issue template (ReVanced#1432)

67ecc13

feat: remember patch options (ReVanced#1449)

62f5ace

brosssh added the ReVanced Manager Compose label Aug 27, 2025

brosssh linked an issue Aug 27, 2025 that may be closed by this pull request

feat: Request POST_NOTIFICATIONS permission in Android 13 and higher #2560

Open

3 tasks

brosssh removed a link to an issue Aug 27, 2025

feat: Request POST_NOTIFICATIONS permission in Android 13 and higher #2560

Open

3 tasks

brosssh linked an issue Aug 27, 2025 that may be closed by this pull request

feat: Request POST_NOTIFICATIONS permission in Android 13 and higher #2560

Open

3 tasks

brosssh commented Aug 27, 2025

View reviewed changes

brosssh requested a review from Axelen123 August 27, 2025 13:52

Axelen123 requested changes Aug 27, 2025

View reviewed changes

brosssh added 3 commits August 28, 2025 10:39

Minor fixes

7c4791f

Refactor

6dbe60e

Refactor of Android11 bug dialog

bea096e

brosssh commented Sep 4, 2025

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt Show resolved Hide resolved

brosssh requested a review from Axelen123 September 4, 2025 20:57

Minor fixes

41b49f1

Axelen123 requested changes Sep 5, 2025

View reviewed changes

Fixes

85a18c1

brosssh changed the title ~~feat(Compose): Component to handle permissions request (A13+)~~ feat: Component to handle permissions request (A13+) Sep 6, 2025

brosssh added 3 commits September 7, 2025 11:16

Fixes

af98a6f

Refactor from vm to state handler

cd46b76

Restored android 11 dialog on + press

9521f66

Axelen123 requested changes Sep 8, 2025

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/RequestPermissionDialog.kt Outdated Show resolved Hide resolved

brosssh and others added 3 commits September 9, 2025 08:31

Should show dialog override, rename state holder

fc7c0a0

Rollback changes to unused file

22d465e

Rollback changes to unused file

e38f4ce

oSumAtrIX force-pushed the compose-dev branch from b1f2e5c to 775c2d5 Compare October 1, 2025 19:54

Ushie changed the base branch from compose-dev to dev October 3, 2025 13:15

Ushie removed the ReVanced Manager Compose label Oct 3, 2025

MarcaDian mentioned this pull request Oct 12, 2025

fix(YouTube - Custom branding): Use ReVanced icon for status bar notification icon ReVanced/revanced-patches#6108

Merged

		("An exception occurred in the remote process while patching." +
		" ${e.originalStackTrace}").logFmt())

Uh oh!

feat: Component to handle permissions request (A13+) #2710

Are you sure you want to change the base?

feat: Component to handle permissions request (A13+) #2710

Uh oh!

Conversation

brosssh commented Aug 27, 2025

Uh oh!

brosssh Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Axelen123 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

brosssh commented Aug 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Axelen123 Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

brosssh Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kitadai31 commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

MarcaDian commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

kitadai31 commented Sep 6, 2025 •

edited

Loading

MarcaDian commented Oct 12, 2025 •

edited

Loading