Skip to content

Commit 2b555f6

Browse files
feat(YouTube - Hide layout components): Add "Hide Emoji and Timestamp buttons" setting (#5992)
1 parent fb87199 commit 2b555f6

File tree

4 files changed

+19
-12
lines changed

4 files changed

+19
-12
lines changed

extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/CommentsFilter.java

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,11 @@
66
@SuppressWarnings("unused")
77
final class CommentsFilter extends Filter {
88

9+
private static final String COMMENT_COMPOSER_PATH = "comment_composer.eml";
10+
911
private final StringFilterGroup chipBar;
1012
private final ByteArrayFilterGroup aiCommentsSummary;
13+
private final StringFilterGroup emojiAndTimestampButtons;
1114

1215
public CommentsFilter() {
1316
var chatSummary = new StringFilterGroup(
@@ -52,6 +55,11 @@ public CommentsFilter() {
5255
"composer_short_creation_button.eml"
5356
);
5457

58+
emojiAndTimestampButtons = new StringFilterGroup(
59+
Settings.HIDE_COMMENTS_EMOJI_AND_TIMESTAMP_BUTTONS,
60+
"|CellType|ContainerType|ContainerType|ContainerType|ContainerType|ContainerType|"
61+
);
62+
5563
var previewComment = new StringFilterGroup(
5664
Settings.HIDE_COMMENTS_PREVIEW_COMMENT,
5765
"|carousel_item",
@@ -64,11 +72,6 @@ public CommentsFilter() {
6472
"super_thanks_button.eml"
6573
);
6674

67-
StringFilterGroup timestampButton = new StringFilterGroup(
68-
Settings.HIDE_COMMENTS_TIMESTAMP_BUTTON,
69-
"composer_timestamp_button.eml"
70-
);
71-
7275
addPathCallbacks(
7376
channelGuidelines,
7477
chatSummary,
@@ -77,9 +80,9 @@ public CommentsFilter() {
7780
comments,
7881
communityGuidelines,
7982
createAShort,
83+
emojiAndTimestampButtons,
8084
previewComment,
81-
thanksButton,
82-
timestampButton
85+
thanksButton
8386

8487
);
8588
}
@@ -93,6 +96,10 @@ boolean isFiltered(String identifier, String path, byte[] buffer,
9396
&& aiCommentsSummary.check(buffer).isFiltered();
9497
}
9598

99+
if (matchedGroup == emojiAndTimestampButtons) {
100+
return path.startsWith(COMMENT_COMPOSER_PATH);
101+
}
102+
96103
return true;
97104
}
98105
}

extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,9 @@ public class Settings extends BaseSettings {
199199
public static final BooleanSetting HIDE_COMMENTS_COMMUNITY_GUIDELINES = new BooleanSetting("revanced_hide_comments_community_guidelines", TRUE);
200200
public static final BooleanSetting HIDE_COMMENTS_CREATE_A_SHORT_BUTTON = new BooleanSetting("revanced_hide_comments_create_a_short_button", TRUE);
201201
public static final BooleanSetting HIDE_COMMENTS_PREVIEW_COMMENT = new BooleanSetting("revanced_hide_comments_preview_comment", FALSE);
202+
public static final BooleanSetting HIDE_COMMENTS_EMOJI_AND_TIMESTAMP_BUTTONS = new BooleanSetting("revanced_hide_comments_emoji_and_timestamp_buttons", FALSE);
202203
public static final BooleanSetting HIDE_COMMENTS_SECTION = new BooleanSetting("revanced_hide_comments_section", FALSE);
203204
public static final BooleanSetting HIDE_COMMENTS_THANKS_BUTTON = new BooleanSetting("revanced_hide_comments_thanks_button", TRUE);
204-
public static final BooleanSetting HIDE_COMMENTS_TIMESTAMP_BUTTON = new BooleanSetting("revanced_hide_comments_timestamp_button", FALSE);
205205

206206
// Description
207207
public static final BooleanSetting HIDE_AI_GENERATED_VIDEO_SUMMARY_SECTION = new BooleanSetting("revanced_hide_ai_generated_video_summary_section", FALSE);

patches/src/main/kotlin/app/revanced/patches/youtube/layout/hide/general/HideLayoutComponentsPatch.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,9 @@ val hideLayoutComponentsPatch = bytecodePatch(
161161
SwitchPreference("revanced_hide_comments_section"),
162162
SwitchPreference("revanced_hide_comments_community_guidelines"),
163163
SwitchPreference("revanced_hide_comments_create_a_short_button"),
164+
SwitchPreference("revanced_hide_comments_emoji_and_timestamp_buttons"),
164165
SwitchPreference("revanced_hide_comments_preview_comment"),
165166
SwitchPreference("revanced_hide_comments_thanks_button"),
166-
SwitchPreference("revanced_hide_comments_timestamp_button"),
167167
),
168168
sorting = PreferenceScreenPreference.Sorting.UNSORTED,
169169
),

patches/src/main/resources/addresources/values/strings.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -441,15 +441,15 @@ If a Doodle is currently showing in your region and this hide setting is on, the
441441
<string name="revanced_hide_comments_create_a_short_button_title">Hide \'Create a Short\' button</string>
442442
<string name="revanced_hide_comments_create_a_short_button_summary_on">Create a Short button is hidden</string>
443443
<string name="revanced_hide_comments_create_a_short_button_summary_off">Create a Short button is shown</string>
444+
<string name="revanced_hide_comments_emoji_and_timestamp_buttons_title">Hide Emoji and Timestamp buttons</string>
445+
<string name="revanced_hide_comments_emoji_and_timestamp_buttons_summary_on">Emoji and Timestamp buttons are hidden</string>
446+
<string name="revanced_hide_comments_emoji_and_timestamp_buttons_summary_off">Emoji and Timestamp buttons are shown</string>
444447
<string name="revanced_hide_comments_preview_comment_title">Hide preview comment</string>
445448
<string name="revanced_hide_comments_preview_comment_summary_on">Preview comment is hidden</string>
446449
<string name="revanced_hide_comments_preview_comment_summary_off">Preview comment is shown</string>
447450
<string name="revanced_hide_comments_thanks_button_title">Hide Thanks button</string>
448451
<string name="revanced_hide_comments_thanks_button_summary_on">Thanks button is hidden</string>
449452
<string name="revanced_hide_comments_thanks_button_summary_off">Thanks button is shown</string>
450-
<string name="revanced_hide_comments_timestamp_button_title">Hide Timestamp button</string>
451-
<string name="revanced_hide_comments_timestamp_button_summary_on">Timestamp button is hidden</string>
452-
<string name="revanced_hide_comments_timestamp_button_summary_off">Timestamp button is shown</string>
453453

454454
<string name="revanced_custom_filter_screen_title">Custom filter</string>
455455
<string name="revanced_custom_filter_screen_summary">Hide components using custom filters</string>

0 commit comments

Comments
 (0)