Skip to content

Conversation

@LisoUseInAIKyrios
Copy link
Contributor

Initial usage of Patcher v22 method instruction filters.

ReVanced/revanced-patcher#329

…tion_filters

# Conflicts:
#	patches/api/patches.api
#	patches/src/main/kotlin/app/revanced/patches/music/interaction/permanentshuffle/PermanentShufflePatch.kt
#	patches/src/main/kotlin/app/revanced/patches/music/misc/spoof/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/music/misc/spoof/SpoofClientPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/SpoofVideoStreamsPatch.kt
…tion_filters

# Conflicts:
#	patches/api/patches.api
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/Fingerprints.kt
…tion_filters

# Conflicts:
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/requests/StreamingDataRequest.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/LicenseActivityHook.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/preference/ReVancedPreferenceFragment.java
#	patches/src/main/kotlin/app/revanced/patches/music/interaction/permanentrepeat/PermanentRepeatPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/interaction/downloads/DownloadsPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/seekbar/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/extension/hooks/ApplicationInitHook.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/shared/Fingerprints.kt
…tion_filters

# Conflicts:
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/requests/StreamingDataRequest.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/LithoFilterPatch.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/ReturnYouTubeDislikeFilter.java
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/viber/ads/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/buttons/action/HideButtonsPatch.kt
…tion_filters

# Conflicts:
#	patches/api/patches.api
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/SpoofVideoStreamsPatch.kt
…tion_filters

# Conflicts:
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/ButtonsFilter.java
#	patches/src/main/kotlin/app/revanced/patches/music/layout/navigationbar/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/spoof/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/buttons/action/HideButtonsPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/player/fullscreen/OpenVideosFullscreenPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/spoofappversion/SpoofAppVersionPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/fix/backtoexitgesture/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/fix/backtoexitgesture/FixBackToExitGesturePatch.kt
…tion_filters

# Conflicts:
#	extensions/music/src/main/java/app/revanced/extension/music/settings/GoogleApiActivityHook.java
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/Utils.java
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/checks/Check.java
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/BaseActivityHook.java
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/ColorPickerPreference.java
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/CustomDialogListPreference.java
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/ToolbarPreferenceFragment.java
#	extensions/twitch/src/main/java/app/revanced/extension/twitch/settings/TwitchActivityHook.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/AlternativeThumbnailsPatch.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/HidePlayerOverlayButtonsPatch.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/theme/SeekbarColorPatch.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/SearchViewController.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/YouTubeActivityHook.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/preference/ExternalDownloaderPreference.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/preference/ReVancedPreferenceFragment.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/sponsorblock/objects/SegmentCategoryListPreference.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/sponsorblock/ui/NewSegmentLayout.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/sponsorblock/ui/SkipSponsorButton.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/sponsorblock/ui/SponsorBlockViewController.java
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/videoplayer/VideoQualityDialogButton.java
#	patches/src/main/kotlin/app/revanced/patches/music/interaction/permanentshuffle/PermanentShufflePatch.kt
#	patches/src/main/kotlin/app/revanced/patches/music/layout/upgradebutton/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/music/layout/upgradebutton/HideUpgradeButtonPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/music/misc/settings/SettingsPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt
…tion_filters

# Conflicts:
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/RemoveTrackingQueryParameterPatch.java
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/privacy/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/privacy/RemoveTrackingQueryParameterPatch.kt
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/youtube/shared/Fingerprints.kt
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/shared/misc/settings/SettingsPatch.kt
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/instagram/hide/navigation/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/music/misc/extension/hooks/ApplicationInitHook.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/video/quality/Fingerprints.kt
@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Nov 8, 2025

20.45.34, ReVanced loop video doesn't work?

I never used the feature so maybe I'm overlooking something.

And the beta crash bug is back again for me. Edit: New patch fixes YT's own bug.

@MarcaDian
Copy link
Contributor

Loop by player button is working for me on 20.45, custom speed doesn't work.

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Nov 8, 2025

I meant Miscellaneous > Loop video. (Edit: issue is fixed). Off topic but I think that setting could be moved to the player menu.

Crash is fixed with a new internal patch.

Was caused by a null device country code in a random map. Maybe it's because I travel so much they can't decide where I live, not sure. 🤷‍♂️

@MarcaDian
Copy link
Contributor

MarcaDian commented Nov 8, 2025

Miscellaneous > Loop video

The loop button in the player controls this setting. I checked again, it works for me, the video starts again at the end.

Maybe it's because I travel so much they can't decide where I live, not sure. 🤷‍♂️

I know at least 4 users who haven't traveled anywhere but they also have crashes after the new interface arrived.

@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@0xrxL
Copy link

0xrxL commented Nov 8, 2025

And the beta crash bug is back again for me.

Do you have any log on which someone can make a patch?

@MarcaDian
Copy link
Contributor

Do you have any log on which someone can make a patch?

Crash is fixed with a new internal patch.

@0xrxL
Copy link

0xrxL commented Nov 8, 2025

Hope it's just a mistake in my code or a new A/B flag.

Ok guys. Luckily it was only a problem on my code: I forgot to enable a patch. 😭

…tion_filters

# Conflicts:
#	extensions/shared/library/src/main/java/app/revanced/extension/shared/Utils.java
#	patches/src/main/kotlin/app/revanced/patches/music/layout/castbutton/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/music/layout/castbutton/HideCastButton.kt
@MarcaDian
Copy link
Contributor

There is also a problem with the right side has no indentation from the edge (settings icons, seekbar, etc.) while the left side has indentation.

Screenshot_2025-10-19-18-22-15-471_app.revanced.android.youtube-edit.jpg

Fixed for me on 20.45

@LisoUseInAIKyrios

This comment was marked as resolved.

@cyberboh
Copy link
Contributor

cyberboh commented Nov 9, 2025

New UI? Just a sucks Screenshot_2025-11-08-12-59-25-382_app revanced android youtube-edit

FYI, I also get this new UI on my another phone which not using Spoof client because I didn't get any playback issue since beginning. In that phone I am using YT 20.14.43 and stable patches version 5.45.0.

@LisoUseInAIKyrios
Copy link
Contributor Author

45685201 - New bold icons

The same flag exists for YT Music. Not sure what version it first appeared but it's in the latest.

@MarcaDian
Copy link
Contributor

MarcaDian commented Nov 9, 2025

To be honest, I'm starting to like the new bold icons) if it was possible to replace the new bolt fullscreen button to old thin as ReVanced buttons (for YouTube), and use the new interface, it would be great.
Because sooner it will be necessary to do it anyway.


I don't like the new "like" button in the music miniplayer, need somehow to hide it.
In previous versions there was a cast button that was hidden.


45685201 - New bold icons

But this does not change the icons of action panel buttons in the player.

8.30 still has the old thin icons.

@MarcaDian
Copy link
Contributor

MarcaDian commented Nov 9, 2025

45702633 - Hides the like button in the music miniplayer.

PS: The feature for blocking functional flags is really convenient, it only took me 3 minutes 😅

…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/music/layout/branding/CustomBrandingPatch.kt
@0xrxL
Copy link

0xrxL commented Nov 10, 2025

@LisoUseInAIKyrios Did you tried to disable the litho threads patch? Maybe the memory leak has been fixed, after all the last layouts changes.

@LisoUseInAIKyrios
Copy link
Contributor Author

Haven't tried.

The single thread change fixes the YT nav bar race issue (can't always correctly filter based on which nav button is selected). So even if the elusive and difficult to reproduce memory issue is resolved, single threaded may still be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants