Skip to content

Commit 295be0a

Browse files
committed
Fixed thread issue with dynamic datasets
1 parent ecaf602 commit 295be0a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/main/java/uk/ac/rdg/resc/edal/ncwms/NcwmsCatalogue.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,15 @@ public ContactInfo getContactInfo() {
168168
}
169169

170170
@Override
171-
public Dataset getDatasetFromId(String datasetId) {
171+
public synchronized Dataset getDatasetFromId(String datasetId) {
172172
Dataset dataset = super.getDatasetFromId(datasetId);
173173
if (dataset != null) {
174174
return dataset;
175175
} else {
176176
/*
177177
* We may have a dynamic dataset. First check the dynamic dataset cache.
178178
*/
179-
if(dynamicDatasetCache != null) {
179+
if (dynamicDatasetCache != null) {
180180
Element element = dynamicDatasetCache.get(datasetId);
181181
if (element != null && element.getObjectValue() != null) {
182182
return (Dataset) element.getObjectValue();
@@ -233,6 +233,7 @@ public Dataset getDatasetFromId(String datasetId) {
233233
/*
234234
* TODO log error
235235
*/
236+
e.printStackTrace();
236237
return null;
237238
}
238239
}

0 commit comments

Comments
 (0)