feat: updating service attachment count (#10)

* feat: updating service attachment count

* docs: updated changelog for v1.0.1

* test: wrong amount of service attachments to test for

Author: burythehammer

CHANGELOG.md

@@ -3,9 +3,15 @@
 All notable changes to this project will be documented in this file.
 See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
 
+## 1.0.1
+
+### Changed
+
+- Changed the hardcoded service attachment count from 40 to 1.
+
 ## 1.0.0
 
 ### Added
 
-- Initial version of the module which provision Private Service Connect service and endpoints for Active-Active and Pro 
-subscriptions and related GCP resources.
+- Initial version of the module which provision Private Service Connect service and endpoints for Active-Active and Pro
+  subscriptions and related GCP resources.

modules/gcp_service_attachments/main.tf

@@ -3,7 +3,7 @@ locals {
   # plan time, we cannot use `service_attachments` from the private service connect endpoint directly
   # as those are only computed after applying the plan. Because of that we need a fixed count
   # here unfortunately.
-  service_attachment_count = 40
+  service_attachment_count = 1
 }
 
 data "google_compute_subnetwork" "subnet" {
@@ -50,4 +50,4 @@ resource "google_dns_response_policy_rule" "redis_response_policy_rules" {
       rrdatas = [google_compute_address.redis_ip_addresses[count.index].address]
     }
   }
-}
+}

test/terraform_private_service_connect_test.go

@@ -14,7 +14,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-const expectNumberOfServiceAttachments = 40
+const expectNumberOfServiceAttachments = 1
 
 func TestTerraformPrivateServiceConnect(t *testing.T) {
 	gcpProject := os.Getenv("GCP_PROJECT_ID")