Regression: Fix Android external dependencies #1084
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package org.godotengine is used both for the Java portion of the editor launched on Android and for the SDK exposed to third party tools and plugins. The recent change to rename the package to org.redotengine has broken all the binary (and source) dependencies of third party software. This changes reverts the package declarations to org.godotengine. However, this can't be merged as is: we first need to identify all the sources that constitute the editor engine on Android, and move those only to org.redotengine. That is necessary to be able to publish the Redot editor on android separately from Godot (and possibly sign applications built with it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT FOR MERGE.
The package org.godotengine is used both for the Java portion of the editor on Android and for the SDK exposed to third party tools and plugins.
The recent change to rename the package to org.redotengine has broken all the binary (and source) dependencies of third party software, changing the signature of the library they use to interact with the engine.
This PR reverts the package declarations to org.godotengine.
However, this can't be merged as is: we first need to identify all the sources that constitute the editor engine on Android, and move those only to org.redotengine. That is necessary to be able to publish the Redot editor on android separately from Godot (and possibly sign applications built with it).