Skip to content
This repository was archived by the owner on Jan 25, 2026. It is now read-only.

Comments

Fix/website#267

Merged
opdev1004 merged 7 commits intomasterfrom
fix/website
Nov 22, 2025
Merged

Fix/website#267
opdev1004 merged 7 commits intomasterfrom
fix/website

Conversation

@opdev1004
Copy link
Contributor

@opdev1004 opdev1004 commented Nov 22, 2025

By submitting this pull request, I confirm the following (please check the boxes):

  • I have read and understood the Contributor Guidelines.
  • I have verified that there are no duplicate pull requests for this request.
  • I believe this submission is valuable to others.
  • I acknowledge that this submission may not be used and the pull request may be closed at the maintainers' discretion.

PR Content:

Related issues (if any):

Screenshots (if applicable):

Additional notes:

Remove dependabot for now and push fixes

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@cloudflare-workers-and-pages
Copy link

Deploying redot-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: be5bc86
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
main-website be5bc86 Nov 22 2025, 09:22 PM

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 22, 2025

Greptile Overview

Greptile Summary

This PR migrates the application from Edge Runtime to Node.js runtime and updates dependencies.

Major changes:

  • Migrated all API routes and layouts from edge to nodejs runtime to support Node.js-specific features (like axios for external API calls)
  • Updated @opennextjs/cloudflare from 1.3.1 to 1.8.0 and wrangler from 4.22.0 to 4.34.0
  • Removed dependabot configuration (no longer automating dependency updates)
  • Improved pre-commit hook to only stage tracked files (git add -u instead of git add .)
  • Added Prettier configuration overrides for JSON files
  • Removed DownloadThreeSteps component from download page (component file remains unused)
  • Added VSCode settings for consistent formatting

Confidence Score: 4/5

  • This PR is generally safe to merge with minor cleanup recommended
  • The runtime migration is necessary and properly implemented across all routes. Dependencies are updated to compatible versions. Minor issue: unused component file should be removed for cleaner codebase.
  • The download page (app/(main)/download/[platform]/page.tsx) leaves an orphaned component that should be cleaned up

Important Files Changed

File Analysis

Filename Score Overview
.github/dependabot.yml 5/5 Removed dependabot configuration file - no longer automating dependency updates
.husky/pre-commit 5/5 Changed git staging from git add . to git add -u to only stage tracked files
app/(main)/download/[platform]/page.tsx 4/5 Removed DownloadThreeSteps component from download page, leaving orphaned component file
app/api/download/route.ts 4/5 Changed runtime from edge to nodejs for GitHub API compatibility
package.json 5/5 Updated @opennextjs/cloudflare from ^1.3.1 to ^1.8.0 and wrangler from ^4.22.0 to ^4.34.0

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PreCommit as Pre-commit Hook
    participant Git as Git
    participant Runtime as Next.js Runtime
    participant API as API Routes
    participant CF as Cloudflare Workers

    Note over Dev,CF: Configuration & Tooling Updates
    
    Dev->>PreCommit: Commit changes
    PreCommit->>PreCommit: Run lint:fix
    PreCommit->>PreCommit: Run format:fix
    PreCommit->>Git: git add -u (only tracked files)
    Git-->>PreCommit: Stage tracked changes only
    PreCommit->>Git: Verify staged changes exist
    
    Note over Runtime,CF: Runtime Migration (Edge → Node.js)
    
    Dev->>Runtime: Deploy application
    Runtime->>API: Route /api/download
    API->>API: Execute with nodejs runtime
    API->>CF: Make external API calls (axios)
    CF-->>API: GitHub API response
    API-->>Runtime: Return download data
    
    Runtime->>API: Route /api/feed.xml
    API->>API: Execute with nodejs runtime
    API-->>Runtime: Return RSS feed
    
    Runtime->>API: Route /api/mirrorlists
    API->>API: Execute with nodejs runtime
    API-->>Runtime: Return mirror list
    
    Note over Dev,CF: Package Updates
    Dev->>Dev: Update @opennextjs/cloudflare 1.3.1→1.8.0
    Dev->>Dev: Update wrangler 4.22.0→4.34.0
    Dev->>Dev: Remove dependabot config
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines 1 to 2
import { DownloadHero } from "@/components/sections/download/DownloadHero";
import { DownloadThreeSteps } from "@/components/sections/download/DownloadThreeSteps";
import { DownloadSupportedPlatform } from "@/components/sections/download/DownloadSupportedPlatform";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The DownloadThreeSteps component at components/sections/download/DownloadThreeSteps.tsx is now unused. Consider deleting the component file and its related ThreeStepsItem dependency if not used elsewhere.

Prompt To Fix With AI
This is a comment left during a code review.
Path: app/(main)/download/[platform]/page.tsx
Line: 1:2

Comment:
**style:** The `DownloadThreeSteps` component at `components/sections/download/DownloadThreeSteps.tsx` is now unused. Consider deleting the component file and its related `ThreeStepsItem` dependency if not used elsewhere.

How can I resolve this? If you propose a fix, please make it concise.

@opdev1004 opdev1004 requested review from a team, decryptedchaos and tindrew November 22, 2025 21:23
@opdev1004 opdev1004 merged commit f4166c2 into master Nov 22, 2025
5 of 8 checks passed
@opdev1004 opdev1004 deleted the fix/website branch November 22, 2025 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants