Utilized NetIds to get drops for structures and barricades rather than find by root.#2
Open
Jdance-Media wants to merge 1 commit intoRestoreMonarchyPlugins:masterfrom
Open
Utilized NetIds to get drops for structures and barricades rather than find by root.#2Jdance-Media wants to merge 1 commit intoRestoreMonarchyPlugins:masterfrom
Jdance-Media wants to merge 1 commit intoRestoreMonarchyPlugins:masterfrom
Conversation
… down on number of ticks required by 48%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier I discovered that
BarricadeDrop.FindByRootFastutilizesGetComponentin order to obtain the BarricadeDrop. Nelson likes to return transforms for new plants and finding barricades in a radius, so this is called fairly often.By utilizing the NetIdRegistry and therefore its built-in dictionaries, you save 31.64 - 48% in tick speed in comparison to the FindByRootFast way. I've tested this alongside RBMKBlaze in relation to a plugin on LC and it gives a noticeable improvement.
This is the new standard and improved way to get
BarricadeDropfrom a Transform. Tons of plugins use the old FindBarricadeByRootTransform way and it can be incredibly problematic.