-
Notifications
You must be signed in to change notification settings - Fork 263
Clang format #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clang format #290
Conversation
You are welcome to add an entry to the CHANGELOG.md as well |
Maybe merge #274 before reformatting whole codebase? |
Good point. However that doesnt explain why thatd break builds lol |
This reverts commit 1e79e8b.
Built artifacts for commit c6f37c8FirmwareClient |
Replacing |
yeah, but ig it helps with readability, but ideally there's proper error handling (another thing afaik @LupusE is atleast partially working on) Anyways, that still WIP... the issue rn is to figure out why clang format breaks the builds... |
100% correct. I doubt this will be possible by anyone in reasonable time. I thought at this amount of errors, I can detect more pattern. But in reality, I was wrong. |
Add clang-format as a formatter and linter to the firmware code
Oh and also run the formatter lol (resulting in the large diffs)