Skip to content

Conversation

douniwan5788
Copy link
Contributor

No description provided.

Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001 iceman1001 merged commit db41596 into RfidResearchGroup:master Aug 23, 2024
12 checks passed
@iceman1001
Copy link
Collaborator

Thats interesting!

@CiRIP
Copy link
Contributor

CiRIP commented Aug 24, 2024

could this present issues when compiling the device code without hitag support?

edit: never mind, just saw it was handled on the client side, so won't affect compiling the device side. it would mean however that hitag cloning would be unavailable for standalone modes. electra support is also missing.

@iceman1001
Copy link
Collaborator

All code which can be turned off and on with compiler directives should be handled in code. This might have change now,
@douniwan5788 may have a second look to verify its all guarded correct.

We should also add this hitag S to lf search now that it works again

@douniwan5788
Copy link
Contributor Author

douniwan5788 commented Aug 24, 2024

could this present issues when compiling the device code without hitag support?

edit: never mind, just saw it was handled on the client side, so won't affect compiling the device side. it would mean however that hitag cloning would be unavailable for standalone modes. electra support is also missing.

Thanks for pointing that out! It won't affect during compilation, but it will go wrong when running the command with SKIP_HITAG. Fixed in #2470

I will look into the standalone mode later.

@douniwan5788
Copy link
Contributor Author

All code which can be turned off and on with compiler directives should be handled in code. This might have change now, @douniwan5788 may have a second look to verify its all guarded correct.

We should also add this hitag S to lf search now that it works again

I'm still figuring out how to differentiate Hitag series properly. Once I'm done cleaning up the Hitag 1/2/S code, I believe I will find a way to add the Hitag series back to lf search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants