Update iclass.c legacy recover error logging #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved error logging to better understand what's happening
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Dont forget to remove it when you find the bug. |
|
This logging shouldn’t interfere with normal operations, just on the
function startup will provide a few messages of what it’s doing or is
failing
…On Mon, 2 Sep 2024 at 18:16, Iceman ***@***.***> wrote:
Dont forget to remove it when you find the bug.
I doubt that many people uses this command to be annoyed with the extra
logging. So we be fine merging it.
—
Reply to this email directly, view it on GitHub
<#2483 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6MVNZQWCUX7EI7X55UXVDZUQ3GRAVCNFSM6AAAAABNP7JWPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGM2TSOBSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved error logging to better understand what's happening