mkversion: Fix readme location #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While building proxmark3 in an environment without `git` installed, I noticed the following errors on stderr: ``` mkversion create test env: 'git': No such file or directory stat: cannot statx '../README.md': No such file or directory ``` The first line "env: 'git': No such file or directory" is expected, as git is not installed. However, the second line "stat: cannot statx '../README.md': No such file or directory" is a real error: we're running from top-level directory, so the correct path for README.md is just "README.md".
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building proxmark3 in an environment without
gitinstalled, I noticed the following errors on stderr:The first line "env: 'git': No such file or directory" is expected, as git is not installed.
However, the second line "stat: cannot statx '../README.md': No such file or directory" is a real error: we're running from top-level directory, so the correct path for README.md is just "README.md".