fix: Hitag S logtrace time #2522
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
armsrc/hitagS.c
Outdated
| AT91C_BASE_TC0->TC_CCR = AT91C_TC_CLKEN | AT91C_TC_SWTRG; | ||
| AT91C_BASE_TC1->TC_CCR = AT91C_TC_CLKEN | AT91C_TC_SWTRG; | ||
| AT91C_BASE_TC0->TC_CCR = AT91C_TC_CLKEN; | ||
| AT91C_BASE_TC1->TC_CCR = AT91C_TC_CLKEN; |
There was a problem hiding this comment.
there is a bug mentioned in the errata of the arm chip, use previous declaration.
There was a problem hiding this comment.
I didn't find any Timer Counter info in the errata section. If you are referring to the reset, the three timer counters are reset together using AT91C_BASE_TCB->TCB_BCR = 1
There was a problem hiding this comment.
No.
And then I will close this PR.
There was a problem hiding this comment.
Yes, that would be the ones.
There was a problem hiding this comment.
Great! Then the reset is already handled together using the SYNC signal (AT91C_BASE_TCB->TCB_BCR = 1) which generates a software trigger for each channel simultaneously. I think it's ready to be merged.
There was a problem hiding this comment.
No,
Revert back the = AT91C_TC_CLKEN | AT91C_TC_SWTRG parts.
There was a problem hiding this comment.
But why? The reset is properly handled by the SYNC signal. Is the redundant code for bug-proofing in case someone copy/paste it elsewhere, or just to maintain consistent code style?
Anyway, I will revert it back. Please reopen this PR
armsrc/hitagS.c
Outdated
| AT91C_BASE_TC1->TC_CCR = AT91C_TC_CLKEN | AT91C_TC_SWTRG; | ||
| AT91C_BASE_TC0->TC_CCR = AT91C_TC_CLKEN; | ||
| AT91C_BASE_TC1->TC_CCR = AT91C_TC_CLKEN; | ||
| AT91C_BASE_TC2->TC_CCR = AT91C_TC_CLKEN; |
There was a problem hiding this comment.
same as previous comment
douniwan5788
force-pushed
the
logtrace
branch
from
9f78b64 to
35c8dfc
Compare
|
Thank you! |
2 participants
No description provided.