Skip to content

Conversation

@ANTodorov
Copy link
Contributor

Tested in the following docker containers

  • opensuse-leap - just make is failing, make PYTHON3_PKGCONFIG=python-3.11 succeed
  • opensuse-tumbleweed - just make succeed, as expected
  • debian-13-trixie - just make succeed, as expected

So, the patch is properly activated only when the make variable is defined

@doegox
Copy link
Contributor

doegox commented Nov 14, 2024

Thanks but this was due to some recent code of mine that needed to be limited to Python 3.10
This should be fixed now, tested in the docker Opensuse Leap as well.

@ANTodorov
Copy link
Contributor Author

Great!
Anyway, I believe it is a good idea to have an option to select which python3 to use if there are several available on the system.
What do you think?

In case of approval I think only the docs/description needs to be reworded accordingly...

@ANTodorov ANTodorov force-pushed the fix_opensuse_leap_build branch from ae2b5cb to dc26c49 Compare November 14, 2024 07:05
@ANTodorov ANTodorov changed the title add workaround to build OpenSUSE Leap 15.x add option to build against non-default python3 package Nov 14, 2024
@doegox
Copy link
Contributor

doegox commented Nov 14, 2024

fair enough, thanks.

@doegox doegox merged commit f3e9a79 into RfidResearchGroup:master Nov 14, 2024
12 checks passed
@ANTodorov ANTodorov deleted the fix_opensuse_leap_build branch November 14, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants