Em4x70 - Major improvements to tracing, stability, and debugability #2785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hw dbg
for controlling verbosity of debug outputThis change provides the framework for more easily supporting a variety of tags.
It is the foundation for work underway to support V4070 tags (e.g., Porsche Boxster)
Because of the new bitstream generation and logging, a surprising characteristic of the legacy code's behavior was brought to light... each of the commands that sent additional data (AUTH, PIN, WRITE) were:
While this was not expected, this PR maintains the legacy behavior, as removal of that behavior resulted in failures of those three commands. This change provides a starting point which will simplify discovering the root cause of the hack.
Future TODO: